Skip to content

fix(preview): reject unsafe local file URLs#2581

Open
GautamSharma99 wants to merge 1 commit into
AgentWrapper:mainfrom
GautamSharma99:fix/preview-file-url-scope
Open

fix(preview): reject unsafe local file URLs#2581
GautamSharma99 wants to merge 1 commit into
AgentWrapper:mainfrom
GautamSharma99:fix/preview-file-url-scope

Conversation

@GautamSharma99

Copy link
Copy Markdown

Summary

  • Create each supervisor-link test socket inside a unique temporary directory.
  • Track accepted sockets and destroy them during teardown.
  • Remove temporary socket directories in afterEach.
  • Centralize test server creation so cleanup stays consistent.

Why

The supervisor-link tests previously used timestamp-based socket paths directly under os.tmpdir() and did not clean up the
parent path afterward. Unique temp dirs plus explicit socket cleanup reduce stale socket/collision risk across repeated or
parallel test runs.

Tests

  • npm --prefix frontend test -- supervisor-link
  • npm --prefix frontend test
  • npm --prefix frontend run typecheck
  • npm run lint
  • git diff --check

@nikhilachale

Copy link
Copy Markdown
Collaborator

Please Join the Discord https://discord.gg/GpMzynvFW and also join calls on 10:00PM everyday accept saturday

@somewherelostt

Copy link
Copy Markdown
Collaborator

Thanks for contributing to Agent Orchestrator.

This PR is being picked up by the current external contributor on-call pair:

If someone is already working on this, please continue as usual.
The on-call pair is added for visibility, tracking, and support, not to take over the work.
If you need help with review, direction, reproduction, or next steps, please tag @neversettle17-101 and @somewherelostt here.
You can also join the AO Discord if you want faster context, want to ask questions live, or just want to follow what the community is building.

You are also welcome to join the AO Discord community.

We do daily Discord calls at 10 PM IST, except Saturday.

Join the session here:
https://discord.gg/H6ZDcUXmq

Come by if you want to see what is being built, ask questions, or just hang around with the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants