[codex] teach orchestrator status command guidance#2227
Conversation
…ator into codex/orchestrator-status-help # Conflicts: # backend/internal/session_manager/manager.go # backend/internal/session_manager/manager_test.go
|
Heads up — after the merge- Note: #2255 covers the same change; happy to close that one as a duplicate if this lands. |
illegalcall
left a comment
There was a problem hiding this comment.
Review findings:
-
Please split the
backend/internal/cli/e2e_test.godaemon-cleanup change out of this PR. Issue #2197 is limited to orchestrator status-command guidance, while this hunk changes unrelated test behavior. More importantly, the five-second timeout only logs and allows the test to pass, which can hide a shutdown regression and leave the daemon child running. A separate fix should make the timeout fail and explicitly terminate/reap the process. -
In
backend/internal/session_manager/manager.go, please retain the existing help sentence and only add the requested status-command line. The issue explicitly describes the existingao --helpguidance and asks to add one line, so rewording that instruction adds unnecessary prompt-behavior churn.
The core ao session ls / ao session get <worker-session-id> guidance and its assertions look correct.
|
@cneuralnetwork — hurry up please, (Also pending: @illegalcall's review asks to split the |
…ator into codex/orchestrator-status-help # Conflicts: # backend/internal/session_manager/manager.go # backend/internal/session_manager/manager_test.go

Summary
Teach orchestrator sessions the existing worker status commands instead of leaving them to guess. The standing orchestrator prompt now points to
ao session ls,ao session get <worker-session-id>, andao --helpas the fallback before inventing commands.Why
The prompt previously listed
ao spawnandao send, then told the orchestrator to track worker progress without naming the real inspection commands. That made orchestrators try nonexistent commands such asao listorao status --sessionbefore eventually discovering help.Changes
orchestratorPrompt.TestSpawnOrchestrator_UsesCoordinatorPromptto assert the status and help hints are present in the orchestrator system prompt.ao stoppolls for shutdown, matching the productionao startbehavior.Testing
env GOTOOLCHAIN=auto GOSUMDB=sum.golang.org GOCACHE=/tmp/ao-go-cache GOPATH=/tmp/ao-gopath go test ./internal/session_managerenv GOTOOLCHAIN=auto GOSUMDB=sum.golang.org GOCACHE=/tmp/ao-go-cache GOPATH=/tmp/ao-gopath go test -race ./internal/session_managerenv GOTOOLCHAIN=auto GOSUMDB=sum.golang.org GOCACHE=/tmp/ao-go-cache GOPATH=/tmp/ao-gopath SHELL=/bin/bash go test -tags e2e -run TestE2E_Lifecycle -v ./internal/clienv GOTOOLCHAIN=auto GOSUMDB=sum.golang.org GOCACHE=/tmp/ao-go-cache GOPATH=/tmp/ao-gopath SHELL=/bin/bash go test -tags e2e -v ./internal/clienv GOTOOLCHAIN=auto GOSUMDB=sum.golang.org GOCACHE=/tmp/ao-go-cache GOPATH=/tmp/ao-gopath SHELL=/bin/bash go test ./...env GOTOOLCHAIN=auto GOSUMDB=sum.golang.org GOCACHE=/tmp/ao-go-cache GOPATH=/tmp/ao-gopath SHELL=/bin/bash npm run lintenv GOTOOLCHAIN=auto GOSUMDB=sum.golang.org GOCACHE=/tmp/ao-go-cache GOPATH=/tmp/ao-gopath SHELL=/bin/bash go test -race ./...Fixes #2197