fix: narrow JSON parse exception in analyze_bi.py - #116
Open
andrewwhitecdw wants to merge 3 commits into
Open
Conversation
analyze_bi.py used a bare while parsing JSONL lines, which could mask KeyboardInterrupt and hide malformed input. Catch json.JSONDecodeError explicitly instead. Adds a regression test that loads the script, feeds it a JSONL file with one invalid line, and asserts valid lines are still parsed. Signed-off-by: Andrew White <andrewh@cdw.com>
The module imported nbformat at top level, but nbformat is not a declared dependency, so tests importing the module failed in CI with ModuleNotFoundError. Move the import into build_notebook(), the only function that uses it.
|
|
The regression test previously only checked that malformed JSON lines are skipped. It did not verify the actual bug fix: narrowing the bare to so non-JSON exceptions are no longer swallowed. Add a second test that monkeypatches to raise and asserts the exception propagates through .
Contributor
Author
|
Repair update: the regression test now verifies the actual fix. In addition to checking that lines are skipped, it asserts that a non-JSON exception () raised inside propagates through instead of being swallowed by the previous bare . This addresses the adversarial audit finding that the original test did not exercise the narrowed exception clause. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
analyze_bi.pyused a bareexcept:while parsing JSONL lines, which could maskKeyboardInterruptand hide malformed input.Fix
Catch
json.JSONDecodeErrorexplicitly.Test
Added
tests/test_diagrams_analyze_bi.pywith a regression test that loads the script, feeds it a JSONL file containing an invalid line, and asserts valid lines are still parsed.Verification
AGENTFIELD_SERVER=http://localhost:9999 pytest tests/test_diagrams_analyze_bi.py -vpasses (1 test).