fix(ai-assistant): added missing focus traps by davids-ensemble · Pull Request #694 · AdobeDocs/adp-devsite

davids-ensemble · 2026-07-07T18:33:59Z

fix(ai-assistant): trap keyboard focus within the chat modal
fix(ai-assistant): trap focus within the clear-confirmation dialog
refactor(ai-assistant): extract shared Tab-wrap logic into trapTabFocus

Screen.Recording.2026-07-07.at.21.42.11.mov

Tab from the last focusable element (send button) now wraps to the first header button (clear), and Shift+Tab from that button wraps back to the last element, instead of leaking focus out of the dialog.

The dialog previously fell into the outer chat-window focus trap, so tabbing from its buttons wrapped to the header behind the overlay. It now owns its own tab trap and stops the keydown from bubbling to the outer handler while it's open.

The window-level trap and the clear-dialog's own trap duplicated the same find-first/last-and-wrap logic. Both now call a single exported trapTabFocus(e, container) helper.

aem-code-sync · 2026-07-07T18:34:03Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run all PSI checks
Re-run failed PSI checks
Re-sync branch

Commits

93250de ✅ (latest)
7d10596 ✅
7f1cad3 ✅

github-actions · 2026-07-07T18:34:40Z

❌ Test Results

Status: Some tests failed!

🔍 Click to view failed tests

📁 test/blocks/code/code.test.js:

❌ Code block > code > data-playground attributes from class
      AssertionError: expected null to equal 'code-session'
        at n.<anonymous> (test/blocks/code/code.test.js:29:63)


📁 test/blocks/columns/columns.test.js:

❌ Columns block > Columns > columns-container
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at n.<anonymous> (test/blocks/columns/columns.test.js:29:117)

❌ Columns block > Columns > buttons
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/columns/columns.test.js:100:86
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/columns/columns.test.js:95:50)


📁 test/blocks/embed/embed.test.js:

❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.


📁 test/blocks/contributors/contributors.test.js:

❌ Contributors block > contributors > firstDiv
      AssertionError: expected null to exist
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:32:28)

❌ Contributors block > contributors > remove divs without children
      AssertionError: expected false to be true
      + expected - actual
      
      -false
      +true
      
      at test/blocks/contributors/contributors.test.js:42:44
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:41:51)

❌ Contributors block > contributors > last update div
      AssertionError: expected '' to equal 'https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md'
      + expected - actual
      
      +https://github.com/AdobeDocs/express-add-ons-docs/commits/main/src/pages/references/index.md
      
      at n.<anonymous> (test/blocks/contributors/contributors.test.js:53:40)

❌ Contributors block > contributors > image list div
      AssertionError: expected null to exist
        at test/blocks/contributors/contributors.test.js:71:27
        at Array.forEach (<anonymous>)
        at n.<anonymous> (test/blocks/contributors/contributors.test.js:69:33)


📁 test/blocks/tab/tab-playground.test.js:

❌ Tab block playground metadata > extracts data-playground attributes via decoratePreformattedCode
      AssertionError: expected null to equal 'tab-session'
        at n.<anonymous> (test/blocks/tab/tab-playground.test.js:17:63)


📁 test/blocks/tab/tab.test.js:

❌ Tab block > Tab Button Structure > tab > button load structure
      AssertionError: expected 'tab-button active' to equal 'tab-button'
      + expected - actual
      
      -tab-button active
      +tab-button
      
      at n.<anonymous> (test/blocks/tab/tab.test.js:60:38)

❌ Tab block > Sub-tabs > sub-tab > attributes
      AssertionError: expected 'subTab1' to equal 'subTab3'
      + expected - actual
      
      -subTab1
      +subTab3
      
      at test/blocks/tab/tab.test.js:135:58
      at NodeList.forEach (<anonymous>)
      at n.<anonymous> (test/blocks/tab/tab.test.js:133:23)

Test Coverage Report

Overall Coverage Summary

Metric	Percentage	Coverage
Statements	58.46%	3867/6614
Branches	86.82%	560/645
Functions	53.25%	131/246
Lines	58.46%	3867/6614

Coverage by File/Directory

File	Statements	Branches	Functions	Lines
blocks/accordion	96.73%	100%	100%	96.73%
blocks/announcement	76.69%	60%	100%	76.69%
blocks/banner	94.28%	62.5%	100%	94.28%
blocks/cards	92.04%	90%	100%	92.04%
blocks/carousel	77.8%	82.35%	71.42%	77.8%
blocks/code	81.81%	60%	100%	81.81%
blocks/columns	66.8%	76.31%	100%	66.8%
blocks/contributors	84.23%	56%	100%	84.23%
blocks/edition	91.37%	57.14%	100%	91.37%
blocks/fragment	17.03%	100%	0%	17.03%
blocks/image-text	57.5%	55.55%	100%	57.5%
blocks/info	96.87%	100%	100%	96.87%
blocks/info-card	100%	100%	100%	100%
blocks/info-columns	75%	100%	100%	75%
blocks/list	59.09%	85.71%	100%	59.09%
blocks/mini-resource-card	98%	87.5%	100%	98%
blocks/product-card	78.57%	94.11%	100%	78.57%
blocks/profile-card	96.29%	100%	100%	96.29%
blocks/site-hero	93.93%	80%	100%	93.93%
blocks/summary	98.36%	88.88%	100%	98.36%
blocks/tab	93.25%	96.87%	100%	93.25%
blocks/table	100%	84.61%	100%	100%
blocks/text	50%	83.33%	50%	50%
blocks/title	84%	66.66%	100%	84%
components	57.83%	78.68%	58.33%	57.83%
scripts	48.95%	95.27%	43.78%	48.95%

Coverage report generated at 2026-07-07T18:34:40.282Z

davids-ensemble added 3 commits July 7, 2026 14:15

fix(ai-assistant): trap keyboard focus within the chat modal

7f1cad3

Tab from the last focusable element (send button) now wraps to the first header button (clear), and Shift+Tab from that button wraps back to the last element, instead of leaking focus out of the dialog.

refactor(ai-assistant): extract shared Tab-wrap logic into trapTabFocus

93250de

The window-level trap and the clear-dialog's own trap duplicated the same find-first/last-and-wrap logic. Both now call a single exported trapTabFocus(e, container) helper.

aem-code-sync Bot deployed to fix-ai-assistant-focus-traps July 7, 2026 18:34 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ai-assistant): added missing focus traps#694

fix(ai-assistant): added missing focus traps#694
davids-ensemble wants to merge 3 commits into
stagefrom
fix-ai-assistant-focus-traps

davids-ensemble commented Jul 7, 2026 •

edited

Loading

Uh oh!

aem-code-sync Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

davids-ensemble commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aem-code-sync Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 7, 2026

❌ Test Results

Test Coverage Report

Overall Coverage Summary

Coverage by File/Directory

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

davids-ensemble commented Jul 7, 2026 •

edited

Loading

aem-code-sync Bot commented Jul 7, 2026 •

edited

Loading