chore(deps): flip lance-graph-contract git deps back to branch=main#223
Conversation
…float-then-flip complete) lance-graph #776 (selection + standing_mask) is merged to main, so the five FLOAT dep sites (ogar-class-view, ogar-render-askama, ogar-doc-ir, ogar-from-ruff, ogar-render-typst) return from the PR branch to branch = "main" and the FLOAT markers come out. Verified: resolves to lance-graph main post-merge; ogar-doc-ir (classview) / ogar-render-typst / ogar-class-view / ogar-render-askama tests green; ogar-from-ruff checks clean with lance-sink enabled.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_efd556d0-7a4c-4eae-a200-9c5d0234b1dc) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_81d2ad7f-9ee2-479c-afbd-e34c5bb47e63) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eff4c4bbe4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # `ogar-class-view` / `ogar-from-ruff` / `ogar-render-askama` crates use. | ||
| # FLOAT: branch = "main" → PR branch until lance-graph #776 merges (flip back to main then). | ||
| lance-graph-contract = { git = "https://github.com/AdaWorldAPI/lance-graph", branch = "claude/ogar-docir-architecture-jjzlig", optional = true } | ||
| lance-graph-contract = { git = "https://github.com/AdaWorldAPI/lance-graph", branch = "main", optional = true } |
There was a problem hiding this comment.
With ogar-doc-ir's classview feature enabled, this dependency now resolves from upstream main, but I inspected upstream crates/lance-graph-contract/src/lib.rs on main and it still does not declare pub mod selection; meanwhile crates/ogar-doc-ir/src/resolve.rs imports lance_graph_contract::selection::{RailGraph, ViewId, ViewRegistry, walk_rails}. The old PR branch did export that module, so switching this line makes the documented feature build, and ogar-render-typst tests that enable it, fail with an unresolved selection import until main actually exposes the module.
Useful? React with 👍 / 👎.
2 participants
What
The float-then-flip completion for the DocIr arc: lance-graph #776 (selection rail walk + standing_mask) is merged to lance-graph main, so the five FLOAT dep sites return from the PR branch to
branch = "main"and the FLOAT markers come out:ogar-class-viewogar-render-askamaogar-doc-irogar-from-ruffogar-render-typstThis unpins OGAR main from the now-merged
claude/ogar-docir-architecture-jjzligbranch on lance-graph (which can be deleted once this lands — until then it must survive, since main's manifests still reference it).Verification
cargo update -p lance-graph-contractresolves to lance-graph main post-#776 (538bd55c).ogar-doc-ir(--features classview, 27),ogar-render-typst(5 + 2 dual-render),ogar-class-view,ogar-render-askama(61).ogar-from-ruffchecks clean withlance-sinkenabled.🤖 Generated with Claude Code
https://claude.ai/code/session_01HCghCf6rxf2wcqi2cor6RD
Generated by Claude Code