revert: tear down the DocIr composition arc (#218, #219, #220) — restart from scratch#221
Closed
AdaWorldAPI wants to merge 3 commits into
Closed
revert: tear down the DocIr composition arc (#218, #219, #220) — restart from scratch#221AdaWorldAPI wants to merge 3 commits into
AdaWorldAPI wants to merge 3 commits into
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6bc440d9-8565-49f9-8d5d-37ac1243a5fc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Operator-directed full teardown of this arc's work, ahead of a from-scratch restart. Three clean
git revert -m 1commits, newest first:crates/ogar-doc-ir/src/project.rs, theclassviewfeature, and thelance-graph-contractdep.crates/ogar-doc-ir/src/compose.rs(DocNode / ObjectSlot / ResolutionMode /ogar://).docs/DOCIR-COMPOSITION-GROUNDING.md, the lib.rs doc-comment additions, and this arc's DISCOVERY-MAP entries.Net: −1,217 lines;
ogar-doc-irreturns exactly to its pre-arc W1 observation-IR state.Why
A three-reviewer audit found the arc built an address/storage type skeleton while the directive's payload — the resolution-and-rendering pipeline (resolve ObjectSlot → renderer-neutral FieldView enum → the same document through Askama HTML and Typst), proven by a vertical slice — was never started. Rather than patch types that nothing consumes, the operator directed: delete everything, start from scratch. The restart will be slice-first — every type earns its existence by being consumed by a resolver/renderer in the same PR.
Deliberately NOT touched (other sessions' work)
docs/DOCIR-COMPOSITION-LAYER.md(different branch/session).lib.rsbase,66ecc88/c31830b) — predates this arc.Ledger note
The reverts remove this arc's DISCOVERY-MAP entries. The append-only canon normally forbids deleting ledger entries; this is a direct operator override ("delete everything you did"), and the entries remain recoverable in git history via the reverted merges.
Verification (Rust 1.95)
cargo test -p ogar-doc-ir→ green at the reverted state (W1 tests intact).🤖 Generated with Claude Code
Generated by Claude Code