feat(ogar-emitter): emit include!-safe projection headers (// not //!)#214
Merged
Merged
Conversation
emit_projection_adapters led with //! inner-doc lines, which rustc rejects (E0753) when the generated file is include!'d into a module at a non-start position — exactly the consumer adoption pattern (include! the generated impl next to a private row type as the live From). Switch the two header lines to plain // line comments so the emitted file is include!-safe anywhere; a standalone-module consumer can carry its doc separately. Golden test updated. 4/4 emitter tests green. Generated by [Claude Code](https://claude.com/claude-code)
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_5d0192da-81d4-4b02-9f4e-1103df6c4637) |
AdaWorldAPI
marked this pull request as ready for review
July 19, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emit_projection_adapters(the read-armimpl From<Row> for Domaincodegen from #212) led its output with//!inner-doc lines. That rejects (E0753) when the generated file isinclude!'d into a module at a non-start position — which is exactly the consumer adoption pattern:include!the generated impl next to a private row type as the liveFrom.This switches the two header lines to plain
//line comments, so the emitted file isinclude!-safe anywhere. A standalone-module consumer can carry its doc separately; nothing else about the output changes. Golden test (patient_projection_golden_is_pinned) updated to match.Consumer: MedCare-rs adopts the generated Patient projection as its live
impl From<PatientRow> for Patientviainclude!(MedCare PR #214) — this fix is what makes thatinclude!compile.ogar-emitterprojection tests green.Generated by Claude Code
🤖 Generated with Claude Code
Generated by Claude Code