test(config): skip research-edition guards when AW_RESEARCH_EDITION=true - #143
Merged
ErikBjare merged 1 commit intoSep 7, 2026
Merged
Conversation
The bundle's Research Edition release (v0.14.0b5-research, run 34155142876) failed on every job because release.yml runs patch -> build -> test: scripts/patch_research_edition_config.py flips research_enabled's default to true before `make test` runs, and two guards added in ActivityWatch#138 assert the pristine (non-research) defaults: - test_research_edition_sed_target_is_intact asserts the literal `research_enabled = false` sed target is present and unindented — false by construction once the research patch has run. - test_parse_args_defaults_research_off_without_config asserts research is off by default — the research patch turns it on. Both guards are valuable on standard/PR CI (they catch accidental drift in config.py that would silently break the release patch or ship research defaults to normal users) and must stay in place there. They just shouldn't fire on the very build they exist to protect. Skip both via AW_RESEARCH_EDITION=true, which release.yml already sets at job level for research builds and which `make test` inherits. Verified locally: plain pytest still runs and passes both guards; with AW_RESEARCH_EDITION=true they skip cleanly (2 skipped, 0 failed); and with the research patch actually applied plus the env var set (the real release scenario), the full suite is green. Git-Session-Id: cb3d
Greptile SummaryThis PR prevents two pristine-default configuration guards from failing after the Research Edition release process intentionally patches the default.
Confidence Score: 5/5The PR appears safe to merge; the targeted skips align with the Research Edition release workflow while preserving standard CI coverage. No actionable failures remain: the release environment uses the exact value checked by the tests, and normal test paths leave the variable unset so the guards continue to run. Important Files Changed
Reviews (1): Last reviewed commit: "test(config): skip research-edition guar..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundle's Research Edition release (
v0.14.0b5-research, run 34155142876) failed on every job, both matrices, all platforms.release.ymlrunspatch -> build -> test:scripts/patch_research_edition_config.pyflipsresearch_enabled's default totruebeforemake test, and two guards added in #138 assert the pristine (non-research) defaults —test_research_edition_sed_target_is_intact(asserts the literalresearch_enabled = falsesed target is present/unindented — false by construction once the patch has run) andtest_parse_args_defaults_research_off_without_config(asserts research is off by default — the patch turns it on). Both guards are valuable on standard/PR CI and should stay; they just shouldn't fire on the build they exist to enable.This skips both via
AW_RESEARCH_EDITION=true, whichrelease.ymlalready sets at job level for research builds and whichmake testinherits — no reordering ofrelease.yml's patch/build/test steps needed, and the guards keep protecting standard/PR CI from accidental drift inconfig.py. Companion bundle PR: ActivityWatch/activitywatch#1434 (research profile wiring). The bundle's next research recut will need to bump this submodule pin to pick up this fix beforemake testcan pass again on that lineage.