Conversation
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 5488793 in 2 minutes and 22 seconds. Click for details.
- Reviewed
103lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Makefile:1
- Draft comment:
PHONY list changed: 'package' target removed. Confirm if this removal is intentional. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
2. Makefile:30
- Draft comment:
Review installation paths and systemctl invocation for the service file. Ensure user vs system service behavior is as intended. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure that the behavior is intended, which violates the rules. It does not provide a specific suggestion or point out a specific issue with the code.
3. aw-watcher-window-wayland.service:37
- Draft comment:
Use an absolute path in ExecStart to ensure the binary is located correctly. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 30% vs. threshold = 50% This comment is suggesting a best practice (using absolute paths in systemd service files), which is generally good advice. However, I need to consider: 1) Is this clearly wrong as-is? No, systemd will find binaries in PATH. 2) Is this actionable? Somewhat, but it's unclear what the absolute path should be since it depends on installation location (could be ~/.local/bin/ or /usr/local/bin/). 3) The installation instructions mention "make install" to ~/.local/, but the exact path isn't specified. 4) This feels more like a "best practice" suggestion rather than a clear bug. The rules say comments should be about clear code changes required, not optional improvements unless they're very actionable. The comment could be valid - systemd documentation does recommend absolute paths for security and clarity. Using PATH lookup can be less predictable. However, many systemd services use binary names without absolute paths successfully, especially for user services where the binary is in the user's PATH. While absolute paths are a best practice, this isn't a clear bug - the service will work as written if the binary is in PATH (which it should be after installation). The comment doesn't specify what the absolute path should be, making it less actionable. This feels more like optional advice rather than a required change. This comment is suggesting a best practice improvement rather than fixing a clear bug. Since the service will work as-is (systemd searches PATH), and the comment doesn't provide a specific absolute path to use, it's not sufficiently actionable. According to the rules, I should only keep comments that clearly require a code change.
Workflow ID: wflow_Llfuxp6ZAIynCSde
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This comment was marked as outdated.
This comment was marked as outdated.
|
I did a poor testing job earlier today. This seems a bit more complicated than what I had wished for. The WAYLAND_DISPLAY environment variable may differ (wayland-0 vs wayland-1). Claude suggests to export the variable from the session to systemd. I think it should be possible to do some auto-detection here as a fallback. Or perhaps it's just easier to use aw-qt :-) I'll probably follow up this one in some few days. |
|
I forgot to follow up on this one. I'm running both the server and many watchers through systemd (under the In aw-watcher-afk-prompt Claude set up a Makefile target An alternative could be to have some logic guessing on the correct I will push the |
Add systemd user service file with proper dependencies on aw-server. Includes port readiness check to ensure server is listening before starting the watcher. Note: This is an alternative to running aw-qt (recommended approach). Disclaimer: QA and testing done utilizing real stupidity. Except for that, everything is stiched together using artificial intelligence. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add 60-second timeout to server readiness check to prevent infinite wait - Fix WAYLAND_DISPLAY to use %t (XDG_RUNTIME_DIR) instead of %E (XDG_CONFIG_HOME) Wayland sockets are in $XDG_RUNTIME_DIR, not config directory 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add help target showing all available make targets - Add enable-service target to enable and start systemd service - Add disable-service target to stop and disable service - Add setup-wayland target that auto-detects Sway/Hyprland configs and adds WAYLAND_DISPLAY environment import for systemd services Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
With Restart=on-failure, the watcher would not restart after being stopped cleanly (exit 0). This happened when aw-server stopped and pulled the watcher down via Requires=, then aw-server came back up but the watcher stayed dead — causing multi-hour gaps in recording. Restart=always ensures the watcher comes back regardless of whether it exited cleanly or with an error. The ExecStartPre check already handles waiting for aw-server to be ready. Co-Authored-By: Claude <noreply@anthropic.com>
v3 of both actions is deprecated and now auto-fails on GitHub. Co-Authored-By: Claude <noreply@anthropic.com>
When aw-server is temporarily down, the watcher is stopped by systemd (via Requires=) and then restarted. Previously there was no start-limit configuration, so the default burst limit could cause systemd to stop retrying. Now set StartLimitIntervalSec=7200 / StartLimitBurst=60 (up to 60 attempts in 2 hours) and RestartSec=120 (2-minute gap between attempts) to survive multi-hour aw-server outages. prompt: The window watcher, run from systemd, stops whenever the aw-server is down (even if it's just down for a short while). Can we set up systemd to do auto-restarts? A couple of minutes between each retry is OK, but it should retry restarts for at least an hour or two. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add systemd user service file with proper dependencies on aw-server.
Includes port readiness check to ensure server is listening before
starting the watcher.
Note: This is an alternative to running aw-qt (recommended approach).
Disclaimer: QA and testing done utilizing real stupidity. Except for that, everything is stiched together using artificial intelligence.
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com
Important
Adds systemd service for
aw-watcher-window-waylandand updatesMakefilefor conditional installation and build modes.aw-watcher-window-wayland.serviceto run the watcher withoutaw-qt.aw-serveris ready on port 5600 before starting the watcher.PREFIXbased onSUDO_USERfor user or system-wide installation.installtarget to copy binary and service file to appropriate locations.CARGO_FLAGSandTARGET_DIR.Makefileincludescleantarget to runcargo clean.This description was created by
for 5488793. You can customize this summary. It will automatically update as commits are pushed.