build(deps): require aw-core >=0.5.18 for real profile dir isolation - #169
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Greptile SummaryThis PR raises the minimum and locked aw-core version to 0.5.18 so named profiles receive isolated directories, then makes the corresponding isolation test unconditional.
Confidence Score: 5/5The PR appears safe to merge, with the dependency floor, lockfile, and profile-isolation test aligned. The supported installation paths enforce aw-core 0.5.18, the updated lock remains compatible with the project's Python and transitive dependency constraints, and no changed-code-triggered failure remains. Important Files Changed
Reviews (1): Last reviewed commit: "build(deps): require aw-core >=0.5.18 fo..." | Re-trigger Greptile |
Final step for aw-server in the #1399 profile stack (per the merge order):
aw-corefloor^0.5.8→^0.5.18and update the lock, so--profiledata isolation can't silently be a no-op (as merged, feat(profile): add --profile flag and port/settings isolation #167 with aw-core 0.5.17 gave two profiles the same database)test_named_profile_config_is_isolated_from_default(wasskipif-gated on old aw-core; now runs and passes)Follow-up worth a separate look (not this PR): per the ruling, isolated profile roots should use bare filenames — aw-server still writes
settings-<profile>.jsonand reads[server-<profile>]sections inside already-isolated roots. Cosmetic-consistent today (aw-qt reads the same scheme), but diverges from the bare-filenames contract aw-core/aw-server-rust/aw-client now follow.