fix(aw-sync): forward API key on Android JNI client

[TimeToBuildBob]

Problem

v0.14.0b2 user report (ActivityWatch/aw-android#247): sync appears to run but the chosen folder never changes. Diagnosis:

sync_datastores → ds_from.get_buckets() → GET /api/0/buckets/ → 401 Unauthorized

Desktop aw-sync already forwards [auth].api_key from config.toml (#640). The Android JNI path in aw-sync/src/android.rs still used AwClient::new() with no key. Android does write that key (ConfigManager / Auth Settings) to filesDir/config.toml, the same file the embedded server reads.

Fix

• Enable get_server_config / get_server_config_path on Android (they were cfg(not(target_os = "android"))).
• get_client() reads [auth].api_key from that config and constructs the client with AwClient::new_with_api_key().
• Host is hardcoded 127.0.0.1, so the local key is never attached to a remote.

Testing

• cargo test -p aw-sync --lib -- util::tests — 5 passed, including a new test that commented/empty api_key is treated as absent (matches Android's default commented config.toml).

Submodule bump in aw-android is a follow-up after this merges.

Not a complete close of aw-android#247: remaining items (sync UX feedback, drawer discoverability, category-import save persistence) are tracked on that issue.

[greptile-apps]

Greptile Summary

The PR forwards the embedded Android server’s API key to the loopback sync client and aligns the sync library’s configuration directory with the app-owned files directory.

• Enables Android server-configuration lookup and optional API-key parsing.
• Derives the Android files directory from XDG_DATA_HOME and adds an explicit JNI directory setter.
• Adds coverage for path derivation and empty or commented API keys.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
aw-sync/src/android.rs	Adds Android data-directory initialization and forwards the local configuration’s API key to the loopback client.
aw-sync/src/dirs.rs	Enables Android server-config path resolution and safely derives filesDir from the expected XDG data path.
aw-sync/src/util.rs	Enables shared server-config parsing on Android and tests that empty or commented API keys remain absent.

Sequence Diagram

sequenceDiagram
    participant App as Android app
    participant JNI as aw-sync JNI
    participant Config as filesDir/config.toml
    participant Server as Local aw-server
    App->>JNI: Start sync
    JNI->>JNI: Derive filesDir from XDG_DATA_HOME
    JNI->>Config: Read auth.api_key
    JNI->>Server: Request with optional API key
    Server-->>JNI: Bucket and event data

Loading

_{Reviews (2): Last reviewed commit: "fix(aw-sync): point Android JNI client a..." | Re-trigger Greptile}

[greptile-apps]

Sync library keeps stale data path

If the app supplies a files directory different from the hardcoded fallback, libaw_sync.so reads its independent, uninitialized copy of the server data-directory state, so it loads the wrong config.toml and sends no or an incorrect API key, causing authenticated sync requests to return 401.

Knowledge Base Used:

• Server configuration and platform runtime
• Sync workflows and transport

[TimeToBuildBob]

Fixed in f4b4145.

Agreed: separate cdylibs, independent ANDROID_DATA_DIR. get_client now derives filesDir from XDG_DATA_HOME=$filesDir/data (already set by SyncInterface.kt) so debug/work-profile installs hit the same config.toml as the server. Also added SyncInterface.setDataDir JNI.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.62%. Comparing base (656f3c9) to head (0500a9a).
⚠️ Report is 96 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   70.81%   78.62%   +7.80%     
==========================================
  Files          51       66      +15     
  Lines        2916     5464    +2548     
==========================================
+ Hits         2065     4296    +2231     
- Misses        851     1168     +317     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ErikBjare]

@TimeToBuildBob review

[TimeToBuildBob]

Greptile P1 is real: libaw_sync.so has its own ANDROID_DATA_DIR static, and RustInterface.setDataDir only updates libaw_server.so. The hardcoded default is the release user-0 filesDir — debug (.debug suffix) and work-profile installs still 401.

Fixed in f4b4145. Current Kotlin already sets XDG_DATA_HOME=$filesDir/data; we derive filesDir from that so this .so works without an app change. Also added SyncInterface.setDataDir JNI for an explicit call later.

Release path (the ActivityWatch/aw-android#247 report) was already correct. Kotlin setDataDir call is a follow-up after merge, not a blocker.

[TimeToBuildBob]

@greptileai review

[TimeToBuildBob]

Windows CI (test_push_does_not_reexport_synced_buckets) failed with SQLITE_BUSY / database is locked. First run on this PR was green; this is the known parallel tmp_db path collision (same flake as #655), not the Android API-key change. Can't rerun jobs here (no admin).

Pushed 0500a9a — test-only uniqueness (atomic counter + timestamp), same shape as #655. Local cargo test -p aw-sync --test sync_roundtrip 3/3.

[TimeToBuildBob]

Review landed; you merged this.

Follow-up: ActivityWatch/aw-android#249 bumps aw-server-rust to 2ded7d7 and calls SyncInterface.setDataDir, so the 401 fix is in the app. Debug/work-profile installs need that explicit JNI path; the XDG fallback remains.