updated code to write to user-accessible external data directory - #63
Closed
kovasap wants to merge 1 commit into
Closed
updated code to write to user-accessible external data directory#63kovasap wants to merge 1 commit into
kovasap wants to merge 1 commit into
Conversation
Member
|
I think this PR might be a security issue because any app with access to storage will now be able to read all data logged by ActivityWatch. |
Author
|
True true, I guess that was kinda my motivation : P. I wonder if it would be better to try implementing some kind of auto json export feature instead that can be toggled? |
Author
|
What if there was a way to toggle this feature on and off in the app somehow. Would that be acceptable? |
ErikBjare
force-pushed
the
master
branch
2 times, most recently
from
October 8, 2023 16:37
f47a849 to
548dc78
Compare
Member
|
This would go against standard practice on Android afaik, but the underlying motivation should be addressed by aw-sync now being supported via selecting a dir through SAF, see e.g. #204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently untested