ci(release): publish GitHub releases instead of leaving them as drafts - #259
Merged
ErikBjare merged 2 commits intoSep 14, 2026
Merged
Conversation
v0.14.0 sat as a draft until it was published by hand. Classify tags with assert-play-track.sh so 0.x.x stable releases are not marked prerelease. Git-Session-Id: 087828bb-1476-551f-9400-d18d7f6cd6f9
|
GITHUB_REF_NAME is already set; interpolating github.ref_name into the script lets a crafted tag inject into the release job. Git-Session-Id: f73bd466-b160-5442-a857-61d58fab9408
Contributor
Author
|
@greptileai review |
Contributor
Author
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftover from #236. The original three items there already shipped; this is the
draft:/prerelease:cleanup that was left as a judgment call.What just happened
v0.14.0was created as a draft on 2026-09-11 and sat unpublished until it was published by hand on 2026-09-13. Same class of failure as #236's original report: the Play Store "full changelog" link points at a GitHub release page that non-admins cannot see while the release is a draft.Empty bodies are already fail-closed (#241). Drafts were the remaining hole.
Fix
draft: falsealways. Changelog generation already refuses to ship an empty body, so the review-window draft was only hiding the page. Pre-releases are markedprerelease: trueso they do not steal "Latest release".scripts/assert-play-track.sh(sameX.Y.Z→ stable rule as the Play track).check-version-format-actiontreats0.x.xas unstable per semver, so the oldprerelease: ${{ !(steps.version.outputs.is_stable == 'true') }}would have marked everyv0.14.0-style stable release as a prerelease.Mapping (verified against
assert-play-track.sh --self-test):v0.14.0v0.14.0b2v0.14.0dev…This does not change Play Console promotions.