Skip to content

build(deps): bump aw-qt and aw-tauri for profile-aware autostart - #1437

Open
TimeToBuildBob wants to merge 2 commits into
ActivityWatch:masterfrom
TimeToBuildBob:bump/profile-aware-autostart-pins
Open

build(deps): bump aw-qt and aw-tauri for profile-aware autostart#1437
TimeToBuildBob wants to merge 2 commits into
ActivityWatch:masterfrom
TimeToBuildBob:bump/profile-aware-autostart-pins

Conversation

@TimeToBuildBob

@TimeToBuildBob TimeToBuildBob commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Both profile-aware autostart PRs merged today; this bumps the bundle pins so the next release actually ships them (dependabot's gitsubmodule schedule is monthly).

Submodule From → To Carries
aw-qt 1337c9ae285e77 ActivityWatch/aw-qt#133 — preserve --profile NAME in the OS login command, with distinct Linux desktop files / macOS LaunchAgents / Windows Run values. Also includes ActivityWatch/aw-qt#132 (isolated-root config.toml lookup), already on aw-qt master 19s after #133.
aw-tauri 20a4f40924150c ActivityWatch/aw-tauri#253 — distinct plugin app names per profile; named-profile CLI args; LaunchAgent on macOS so arguments survive login.

Compare: aw-qt · aw-tauri

Research-edition follow-up

The pin bump broke scripts/patch_research_edition_profile.py: named-profile autostart identities (aw-qt-research.desktop, net.activitywatch.aw-qt-research, aw-tauri-research) are now owned by a standard --profile research login item, and the old Linux desktop-path match missed entirely. The patcher now writes edition-specific identities:

  • Qt Linux: activitywatch-research.desktop
  • Qt macOS: net.activitywatch.ActivityWatch-research
  • Tauri: aw-tauri-{BUILD_PROFILE}-edition

Verification

  • aw-qt: pytest tests/test_autostart.py tests/test_profile.py tests/test_profile_config.py — 97 passed.
  • Symptom check against the new aw-qt pin: enabling Start at login for research writes ~/.config/autostart/aw-qt-research.desktop and ~/Library/LaunchAgents/net.activitywatch.aw-qt-research.plist with --profile research, and leaves the default aw-qt.desktop / net.activitywatch.aw-qt.plist entries unchanged.
  • python3 scripts/patch_research_edition_profile.py qt --check and tauri --check both pass; scripts/tests/test_patch_research_edition_profile.py — 25 passed.
  • Local AI review: 5/5, 3/3 consensus, no findings, head 3e5f7d7152.

aw-qt    1337c9a -> e285e77: feat(autostart): preserve named profile at login (ActivityWatch#133)
                             plus fix(config): isolated-root config.toml (ActivityWatch#132)
aw-tauri 20a4f40 -> 924150c: feat(autostart): isolate named profile entries (ActivityWatch#253)

Dependabot's gitsubmodule cadence is monthly, so without this the next
release would not carry named-profile login commands.

Git-Session-Id: 1ee8
@TimeToBuildBob

TimeToBuildBob commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

🤖 AI code review

Safe to merge — no P0/P1 findings

Confidence 5/5

No findings. The diff looks correct to me on this pass.

Previous review passes
commit score findings engine when
db2c83f08043 5/5 0 llm 2026-09-08 17:41 UTC

Reviewed 3e5f7d7152a3 · openrouter/deepseek/deepseek-v4-flash-0731 · llm (in-band) engine · 226s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable regression or repository-rule violation remains in the current changes.

Summary

  • Updates aw-qt and aw-tauri to revisions containing profile-aware login registration.
  • Gives Research Edition Qt autostart entries edition-specific Linux, macOS, and Windows identities.
  • Overrides the Research Edition Tauri autostart identity without removing the upstream profile arguments.
  • Updates fail-closed patch tests for the new upstream implementations.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    Build[Desktop build] --> Standard[Standard edition]
    Build --> Research[Research edition]
    Standard --> Default[Default-profile autostart identity]
    Standard --> Named[Named-profile identity with --profile NAME]
    Research --> Edition[Edition-specific research identity]
    Named -. remains distinct from .-> Edition
Loading

aw-qt#133 / aw-tauri#253 give named profiles their own login entries.
The research edition is profile=research, so the old patcher targets
missed the new Linux path and would have collided with a standard
`--profile research` login item.

Override edition identities explicitly:
- Qt Linux: activitywatch-research.desktop
- Qt macOS: net.activitywatch.ActivityWatch-research
- Tauri: aw-tauri-{BUILD_PROFILE}-edition

Git-Session-Id: 1ee8
@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

@greptileai review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant