build(deps): bump aw-qt and aw-tauri for profile-aware autostart - #1437
Open
TimeToBuildBob wants to merge 2 commits into
Open
build(deps): bump aw-qt and aw-tauri for profile-aware autostart#1437TimeToBuildBob wants to merge 2 commits into
TimeToBuildBob wants to merge 2 commits into
Conversation
aw-qt 1337c9a -> e285e77: feat(autostart): preserve named profile at login (ActivityWatch#133) plus fix(config): isolated-root config.toml (ActivityWatch#132) aw-tauri 20a4f40 -> 924150c: feat(autostart): isolate named profile entries (ActivityWatch#253) Dependabot's gitsubmodule cadence is monthly, so without this the next release would not carry named-profile login commands. Git-Session-Id: 1ee8
Contributor
Author
🤖 AI code reviewSafe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Previous review passes
Reviewed Maintainer commands
|
Contributor
aw-qt#133 / aw-tauri#253 give named profiles their own login entries.
The research edition is profile=research, so the old patcher targets
missed the new Linux path and would have collided with a standard
`--profile research` login item.
Override edition identities explicitly:
- Qt Linux: activitywatch-research.desktop
- Qt macOS: net.activitywatch.ActivityWatch-research
- Tauri: aw-tauri-{BUILD_PROFILE}-edition
Git-Session-Id: 1ee8
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both profile-aware autostart PRs merged today; this bumps the bundle pins so the next release actually ships them (dependabot's gitsubmodule schedule is monthly).
aw-qt1337c9a→e285e77--profile NAMEin the OS login command, with distinct Linux desktop files / macOS LaunchAgents / Windows Run values. Also includes ActivityWatch/aw-qt#132 (isolated-rootconfig.tomllookup), already onaw-qtmaster 19s after #133.aw-tauri20a4f40→924150cCompare: aw-qt · aw-tauri
Research-edition follow-up
The pin bump broke
scripts/patch_research_edition_profile.py: named-profile autostart identities (aw-qt-research.desktop,net.activitywatch.aw-qt-research,aw-tauri-research) are now owned by a standard--profile researchlogin item, and the old Linux desktop-path match missed entirely. The patcher now writes edition-specific identities:activitywatch-research.desktopnet.activitywatch.ActivityWatch-researchaw-tauri-{BUILD_PROFILE}-editionVerification
aw-qt:pytest tests/test_autostart.py tests/test_profile.py tests/test_profile_config.py— 97 passed.aw-qtpin: enabling Start at login forresearchwrites~/.config/autostart/aw-qt-research.desktopand~/Library/LaunchAgents/net.activitywatch.aw-qt-research.plistwith--profile research, and leaves the defaultaw-qt.desktop/net.activitywatch.aw-qt.plistentries unchanged.python3 scripts/patch_research_edition_profile.py qt --checkandtauri --checkboth pass;scripts/tests/test_patch_research_edition_profile.py— 25 passed.3e5f7d7152.