Repository navigation
Conversation
Contributor
[Medium impact] The changes since the previous review appear safe to merge. SummaryThis PR replaces several regex operations with string replacements and simplifies other patterns.
Reviews (2) · Last reviewed commit: "tiny fix" · Reviewed by Greptile |
Contributor
Author
|
easy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only output change is that the word count (showfileinfo.js) increased by + 1
The replacement itself becamr 10-20% faster (I cant provide a super precise benchmark, I am able to use only jsbench.me website [It is precise and consistent regarding replacements and regex])
I cant provide before and after numbers.
Every commit has been made with the mobile ui of github website. I cant use dev tools well, nor have I skills to produce the benchmark.
The improvements are so simple that there is no need imo.