Skip to content

feat(search): remember Search in Files patterns - #3082

Open
A1phaCat wants to merge 2 commits into
Acode-Foundation:mainfrom
A1phaCat:codex/search-in-files-history
Open

A1phaCat wants to merge 2 commits into
Acode-Foundation:mainfrom
A1phaCat:codex/search-in-files-history

Conversation

@A1phaCat

@A1phaCat A1phaCat commented Nov 15, 2026 •

Copy link
Copy Markdown

Summary

  • reuse the existing persisted search/replace history in Search in Files
  • add history pickers and Arrow Up/Down recall for both pattern fields
  • preserve multiline entry, exact whitespace, and literal HTML-like patterns
  • reset recall state after user input such as context-menu paste
  • add focused coverage for recall, selection, and persistence integration

Closes #3037.

Validation

  • npx biome check src/lib/searchHistory.js src/sidebarApps/searchInFiles/index.js src/sidebarApps/searchInFiles/styles.scss tests/unit/searchHistory.test.js tests/unit/searchInFilesHistory.test.js tests/unit/searchReplaceAll.test.js
  • npx vitest run tests/unit/search*.test.js tests/unit/search*.test.ts tests/unit/nativeSearchProcessing.test.js (39 tests passed)
  • npm run typecheck -- --pretty false

The broader local suite passed 94/96 test files (872/873 tests). Its two unrelated environment failures were the existing canvas test requiring a global Element, and the Java formatter fixture resolving a WASM path through a URL-encoded workspace directory. The focused tests and typecheck pass.

@greptile-apps

greptile-apps Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; all four previous findings are addressed.

Summary

Search in Files now shares the saved search and replacement history, with picker buttons and keyboard recall.

  • Search in Files remembers patterns and lets people bring them back.

Reviews (2) · Last reviewed commit: "fix: preserve search pattern semantics" · Reviewed by Greptile

Comment thread src/sidebarApps/searchInFiles/index.js Resolved
Comment thread src/sidebarApps/searchInFiles/index.js Resolved
Comment thread src/sidebarApps/searchInFiles/index.js Resolved
Comment thread src/sidebarApps/searchInFiles/index.js Resolved
@AuDevTist1C

Copy link
Copy Markdown
Contributor

As the test failure is unrelated to this PR, refer to #3077 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

feat(search): remember recent search/replace patterns in Search in files

2 participants