Repository navigation
Conversation
Contributor
[Medium impact] The PR appears safe to merge; all four previous findings are addressed. SummarySearch in Files now shares the saved search and replacement history, with picker buttons and keyboard recall.
Reviews (2) · Last reviewed commit: "fix: preserve search pattern semantics" · Reviewed by Greptile |
Contributor
|
As the test failure is unrelated to this PR, refer to #3077 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3037.
Validation
npx biome check src/lib/searchHistory.js src/sidebarApps/searchInFiles/index.js src/sidebarApps/searchInFiles/styles.scss tests/unit/searchHistory.test.js tests/unit/searchInFilesHistory.test.js tests/unit/searchReplaceAll.test.jsnpx vitest run tests/unit/search*.test.js tests/unit/search*.test.ts tests/unit/nativeSearchProcessing.test.js(39 tests passed)npm run typecheck -- --pretty falseThe broader local suite passed 94/96 test files (872/873 tests). Its two unrelated environment failures were the existing canvas test requiring a global
Element, and the Java formatter fixture resolving a WASM path through a URL-encoded workspace directory. The focused tests and typecheck pass.