You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I’ve prepared a focused fix for this issue in my fork.
The change makes waitForPlugin() consistently resolve to true after a pending plugin finishes loading. I’ve also added regression tests covering successful loading, already-loaded plugins, and failed loading.
@pwnprakashgh Sure, open a PR. The fix is fine, but the test is weak (it slices acode.js by exact text, so any refactor breaks it). Also run pnpm check, the formatting is off (the repo uses tabs).
Activity
pwnprakashgh commentedon Nov 13, 2026
Hi maintainers!
I’ve prepared a focused fix for this issue in my fork.
The change makes waitForPlugin() consistently resolve to true after a pending plugin finishes loading. I’ve also added regression tests covering successful loading, already-loaded plugins, and failed loading.
My branch: https://github.com/pwnprakashgh/acode/tree/fix/wait-for-plugin-resolves-true-2938
I noticed that PR #2955 also modifies this callback as part of a broader improvement.
Would a separate, smaller PR for #2938 be useful, or would you prefer that I hold off to avoid duplicating work?
I’m new to contributing to this project and happy to follow your guidance. Thanks!
bajrangCoder commentedon Nov 13, 2026
@pwnprakashgh Sure, open a PR. The fix is fine, but the test is weak (it slices
acode.jsby exact text, so any refactor breaks it). Also runpnpm check, the formatting is off (the repo uses tabs).