Repository navigation
#2092 skip lint-staged on feature branches; CI lints on PRs - #2674
Open
Pushpak731 wants to merge 2 commits into
Open
Pushpak731 wants to merge 2 commits into
Pushpak731 wants to merge 2 commits into
Conversation
The pre-commit hook now only runs lint-staged when committing directly to main. On feature branches it prints a skip message instead, since the PR's CI (npm run lint in code-test.yml) already catches lint issues. TypeScript d.ts generation still runs on every commit.
…itional lint-staged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR details
What changes did you make? (Give an overview)
The pre-commit hook now only runs
lint-stagedwhen committing directly tomain. On feature branches it prints a skip message instead, since the PR's CI (npm run lintincode-test.yml) already runs the same lint on every PR — keeping local commits fast without losing coverage. The TypeScriptd.tsgeneration still runs on every commit.Further details (optional)
The hook checks
git branch --show-currentand skipslint-stagedfor any branch other thanmain/master. This means:Checklist