Repository navigation
#2106 cdp: honor skipInteraction flag in build's purge prompt - #2672
Open
Pushpak731 wants to merge 2 commits into
Open
Pushpak731 wants to merge 2 commits into
Pushpak731 wants to merge 2 commits into
Conversation
The build() method's deploy-folder purge prompt checked whether OPTIONS.purge was already set but never checked skipInteraction, so mcdev cdp --y still prompted. The prompt is now skipped when the flag is set, and purge defaults to true (the same default the confirm dialogue uses).
…duplicate import)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR details
What changes did you make? (Give an overview)
The
build()method's deploy-folder purge prompt only checked whetherOPTIONS.purgewas already set, neverskipInteraction. Runningmcdev cdp --ystill triggered the interactive confirm. The prompt is now skipped when the flag is set, andpurgedefaults totrue(the same default the confirm dialogue uses).Further details (optional)
Root cause:
mcdev cdpcallsMcdev.build()internally (viaDevOps.buildDeltaDefinitions). The purge check at that call site wastypeof Util.OPTIONS.purge !== 'boolean'— it has noskipInteractionguard, unlike the equivalent prompt indevops.jswhich correctly checks!Util.skipInteraction.Fix: add
&& !Util.OPTIONS.skipInteractionto the condition, plus anelse ifthat setspurge = true(the confirm's default) so the downstream deploy-folder purge still runs.Checklist