fix: prevent double-free in merge_sort (CVE-2021-31996)#7
Open
baima365-web wants to merge 1 commit into
Open
Conversation
…r::read() The original merge() function used ptr::read() to extract elements from the left/right vectors. This moves ownership out of the Vec, causing double-free when the Vec is dropped. Fix: Add Clone bound and use clone() to copy elements instead of moving them. Added regression test for String type (T: Drop). Fixes CVE-2021-31996 / GHSA-jh37-772x-4hpw / Issue AbrarNitk#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge_sort::merge()usesptr::read()to extract elements fromleft/rightvectors. This moves ownership out of the Vec, causing double-free when the Vec is dropped.PoC
Fix
Clonebound tomerge()andmerge_sort()ptr::read()withptr::read().clone()to copy instead of moveStringtype (T: Drop)References
T: Drop#1: 'merge_sort::merge()' crashes with double-free forT: Drop#1