Repository navigation
Regression tests for repository URLs, the create flow and the repository form - #10
Merged
Merged
Conversation
repositoryDistributions is tested against a mock server: the three kinds of binding, the paged scan across pages, a failed load rejecting with a readable message, and the not-served rule for deb. The file Distributions tab is tested for the server's base_url and the manifest line built from it. The list handler of the test utilities can now filter rows the way a server filter does.
…mp check The shared create flow is tested by the requests it sends: blocked before the first POST when the name or base path is taken or cannot be checked, the repository then the distribution in that order, and a refused distribution leaving the repository alone with the server's reason and no retry or rollback. The settings module is tested to refuse a malformed build commit with a message naming PULP_UI_COMMIT. The node test project now also collects tests under config/.
The create-distribution box is offered unticked on create only, a base path under a configured reserved prefix is refused with Save blocked, retained versions starts empty and shows the server's refusal, and a double click on Save reaches the save handler once, including a second click that arrives before the page has re-rendered.
The create page saves null retained versions by default, shows the server's refusal of 0 and sends one POST for a double click. The edit page sends one PUT and creates neither a repository nor a distribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit and component tests for how a repository's served URLs are found, the shared create flow, the repository form, the file repository create and edit pages, and the build stamp check.
No production source is changed. The suite also passes in shuffled order.