Repository navigation
Conversation
cpp/externalLibs/Filesystem/filesystem.hpp is a vendored copy of gulrak/filesystem v1.3.2 (GHC_FILESYSTEM_VERSION 10302L), which predates that library's Emscripten support. Emscripten defines __unix__ but not __linux__, and none of the branches in the GHC_OS_DETECTED chain match it, so the header stops at #error "Operating system currently not supported!" and the library cannot be compiled to WebAssembly. Map __EMSCRIPTEN__ onto the existing GHC_OS_LINUX branch: Emscripten's POSIX layer provides everything that branch selects. The new #elif is unreachable unless __EMSCRIPTEN__ is defined, so no existing platform changes preprocessor state and no behaviour changes for any current target. Upstream ghc::filesystem handles Emscripten natively as of v1.5.x (it defines GHC_OS_WEB), so bumping the vendored copy would remove the need for this edit. This commit is the minimal alternative to that bump. Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of RA-Consulting-GmbH#230 — tracking only. Do not merge.
Upstream PR: RA-Consulting-GmbH#230
Why this PR exists
Every fix this organisation depends on is written as a self-contained, single-commit
upstream contribution rather than a local patch, so that a fork is only needed for as
long as its contributions are unmerged.
That convention has one weakness: an upstream PR is easy to lose track of, because it
lives in someone else's repository and closes on someone else's schedule. This mirrored PR
is the counterweight — an open PR in our own fork for every contribution still pending
upstream, so the set of things we are carrying is visible from our own repository list.
It is closed when the upstream PR is merged or rejected, not before.
Contents
A single commit, identical in content to the upstream PR head:
feature/ghc-filesystem-emscripten->masterWhere it is used
Not consumed by the ASAM UML pipeline; tracked here so the contribution is not lost.