Skip to content

[mirror] fix(loader): pass injected parameters through the import loader - #3

Open
jdsika wants to merge 1 commit into
masterfrom
feature/import-loader-injected-parameters
Open

jdsika wants to merge 1 commit into
masterfrom
feature/import-loader-injected-parameters

Conversation

@jdsika

@jdsika jdsika commented Sep 14, 2026

Copy link
Copy Markdown

Mirror of RA-Consulting-GmbH#231 — tracking only. Do not merge.

Upstream PR: RA-Consulting-GmbH#231

Why this PR exists

Every fix this organisation depends on is written as a self-contained, single-commit
upstream contribution rather than a local patch, so that a fork is only needed for as
long as its contributions are unmerged.

That convention has one weakness: an upstream PR is easy to lose track of, because it
lives in someone else's repository and closes on someone else's schedule. This mirrored PR
is the counterweight — an open PR in our own fork for every contribution still pending
upstream, so the set of things we are carrying is visible from our own repository list.

It is closed when the upstream PR is merged or rejected, not before.

Contents

A single commit, identical in content to the upstream PR head:

feature/import-loader-injected-parameters -> master

Where it is used

Not consumed by the ASAM UML pipeline; tracked here so the contribution is not lost.

XmlScenarioImportLoader::Load(messageLogger, injectedParameters) forwards to the
inner loader's single-argument overload, so the injected parameter map is
dropped before parameter resolution ever sees it. Every embedder that resolves
catalogs loses parameter injection silently — including openScenarioReader,
which reads its -p parameter file, echoes the parameters it found, and then
resolves the scenario as if none had been given, because CheckFile always goes
through ExecuteImportParsingV1_x.

Forward the map to the inner loader. The same line is affected in all four
version loaders (v1_0, v1_1, v1_2, v1_3); the non-import
XmlScenarioLoaderFactory path was already correct, which is why the behaviour
depends on whether catalogs are resolved.

Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant