Repository navigation
Conversation
XmlScenarioImportLoader::Load(messageLogger, injectedParameters) forwards to the inner loader's single-argument overload, so the injected parameter map is dropped before parameter resolution ever sees it. Every embedder that resolves catalogs loses parameter injection silently — including openScenarioReader, which reads its -p parameter file, echoes the parameters it found, and then resolves the scenario as if none had been given, because CheckFile always goes through ExecuteImportParsingV1_x. Forward the map to the inner loader. The same line is affected in all four version loaders (v1_0, v1_1, v1_2, v1_3); the non-import XmlScenarioLoaderFactory path was already correct, which is why the behaviour depends on whether catalogs are resolved. Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of RA-Consulting-GmbH#231 — tracking only. Do not merge.
Upstream PR: RA-Consulting-GmbH#231
Why this PR exists
Every fix this organisation depends on is written as a self-contained, single-commit
upstream contribution rather than a local patch, so that a fork is only needed for as
long as its contributions are unmerged.
That convention has one weakness: an upstream PR is easy to lose track of, because it
lives in someone else's repository and closes on someone else's schedule. This mirrored PR
is the counterweight — an open PR in our own fork for every contribution still pending
upstream, so the set of things we are carrying is visible from our own repository list.
It is closed when the upstream PR is merged or rejected, not before.
Contents
A single commit, identical in content to the upstream PR head:
feature/import-loader-injected-parameters->masterWhere it is used
Not consumed by the ASAM UML pipeline; tracked here so the contribution is not lost.