Skip to content

[mirror] fix(v1_3): interpret a missing Orientation/@type as relative - #2

Open
jdsika wants to merge 1 commit into
masterfrom
feature/orientation-type-default-v1_3
Open

jdsika wants to merge 1 commit into
masterfrom
feature/orientation-type-default-v1_3

Conversation

@jdsika

@jdsika jdsika commented Sep 14, 2026

Copy link
Copy Markdown

Mirror of RA-Consulting-GmbH#232 — tracking only. Do not merge.

Upstream PR: RA-Consulting-GmbH#232

Why this PR exists

Every fix this organisation depends on is written as a self-contained, single-commit
upstream contribution rather than a local patch, so that a fork is only needed for as
long as its contributions are unmerged.

That convention has one weakness: an upstream PR is easy to lose track of, because it
lives in someone else's repository and closes on someone else's schedule. This mirrored PR
is the counterweight — an open PR in our own fork for every contribution still pending
upstream, so the set of things we are carrying is visible from our own repository list.

It is closed when the upstream PR is merged or rejected, not before.

Contents

A single commit, identical in content to the upstream PR head:

feature/orientation-type-default-v1_3 -> master

Where it is used

Not consumed by the ASAM UML pipeline; tracked here so the contribution is not lost.

The UML model this generator consumes documents the interpretation, and it
changed with OpenSCENARIO 1.3. For Orientation::type
(EAID_5C58550C_F448_4d97_9367_081D3A5AD202):

  OpenSCENARIO_Ea_1.3.0.xmi: "Relative or absolute definition. Missing type
                              value is interpreted as relative."
  OpenSCENARIO_Ea_1.2.0.xmi: "... Missing type value is interpreted as absolute."
  OpenSCENARIO_Ea_1.1.0.xmi: "... Missing type value is interpreted as absolute."

In each the attribute carries an empty <initial/>, and OpenSCENARIO.xsd declares
no default either, so the only source of the emitted value is the generator's
hand-maintained DefaultValues_*.json - which still says "absolute" for 1.3.

Set it to "relative" for 1.3 only, and apply the resulting member initializer in
the checked-in generated header so the tree stays consistent until the next
generation run. v1_0-v1_2 keep ABSOLUTE, which their models call for.

A v1.3 document that omits Orientation/@type therefore now reads back as
RELATIVE. _isSetType stays false for an absent attribute, so callers that
distinguish "absent" from "set" are unaffected.

Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant