Skip to content

fix(wallet_screening): load manifest.yaml in skill.manifest property#171

Merged
rosspeili merged 2 commits into
ARPAHLS:mainfrom
Hendobox:fix/wallet-screening-manifest-165
Jun 15, 2026
Merged

fix(wallet_screening): load manifest.yaml in skill.manifest property#171
rosspeili merged 2 commits into
ARPAHLS:mainfrom
Hendobox:fix/wallet-screening-manifest-165

Conversation

@Hendobox

Copy link
Copy Markdown
Contributor

Summary

  • Load manifest.yaml in WalletScreeningSkill.manifest (same pattern as pdf_form_filler and other registry skills)
  • Add test_wallet_screening_manifest so skill.manifest matches SkillLoader bundle metadata

Fixes #165

Test plan

  • pytest tests/skills/finance/test_wallet_screening.py -q (10 passed)
  • WalletScreeningSkill().manifest returns full metadata, not {}

WalletScreeningSkill.manifest returned {} while manifest.yaml held full
metadata. Load from the bundle directory like other registry skills and
add a framework test asserting consistency with SkillLoader.

Fixes ARPAHLS#165
@rosspeili

Copy link
Copy Markdown
Contributor

Thanks for this @Hendobox

Before merge, please add these three items:

  1. Bundle test, Update skills/finance/wallet_screening/test_skill.py to use the standard test_skill_manifest_consistency(skill, manifest) pattern (replace test_manifest_schema that reads yaml only). Bundle tests should assert skill.manifest matches manifest.yaml, same as our other registry skills.

  2. CHANGELOG, Add a one-line entry under [Unreleased]Fixed for wallet_screening manifest loading.

  3. Manifest name, In manifest.yaml, set name to finance/wallet_screening (registry ID should match the path under skills/). Check loader/tests still pass after the rename.

Once those are in, this should be good to merge. <3

…GELOG, manifest name

Use test_skill_manifest_consistency in bundle tests, set manifest name to
finance/wallet_screening, and document the manifest loading fix in CHANGELOG.
@rosspeili

Copy link
Copy Markdown
Contributor

Henry @Hendobox, thanks for the follow-up, this covers everything and it looks good to merge.

One heads-up for after merge: with name: finance/wallet_screening, Gemini/Claude tool names change from wallet_screening, you can align the wallet check examples/docs in a quick follow-up or hotfix. Nothing blocking this PR so I'll merge as is. <3

@rosspeili rosspeili merged commit 035e09d into ARPAHLS:main Jun 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [wallet_screening]: skill.manifest returns {} instead of loading manifest.yaml

2 participants