fix(wallet_screening): load manifest.yaml in skill.manifest property#171
Conversation
WalletScreeningSkill.manifest returned {} while manifest.yaml held full
metadata. Load from the bundle directory like other registry skills and
add a framework test asserting consistency with SkillLoader.
Fixes ARPAHLS#165
|
Thanks for this @Hendobox Before merge, please add these three items:
Once those are in, this should be good to merge. <3 |
…GELOG, manifest name Use test_skill_manifest_consistency in bundle tests, set manifest name to finance/wallet_screening, and document the manifest loading fix in CHANGELOG.
|
Henry @Hendobox, thanks for the follow-up, this covers everything and it looks good to merge. One heads-up for after merge: with |
Summary
manifest.yamlinWalletScreeningSkill.manifest(same pattern aspdf_form_fillerand other registry skills)test_wallet_screening_manifestsoskill.manifestmatchesSkillLoaderbundle metadataFixes #165
Test plan
pytest tests/skills/finance/test_wallet_screening.py -q(10 passed)WalletScreeningSkill().manifestreturns full metadata, not{}