fix(novelty_extractor): mock embeddings in bundle tests for offline CI#169
Merged
rosspeili merged 1 commit intoJun 13, 2026
Merged
Conversation
HuggingFace 429 rate limits caused pytest skills/ to fail in GitHub Actions. Bundle tests now use deterministic keyword vectors instead of downloading fastembed models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for CI failures after #159:
novelty_extractorbundle tests no longer call realfastembed/ HuggingFace. They mock_get_modelwith deterministic keyword vectors sopytest skills/stays offline and avoids 429 rate limits.No changes to
skill.pyor runtime behavior — test-only.Refs #159
Description
After bundle tests entered CI,
novelty_extractortried to downloadbge-small-en-v1.5from HuggingFace on every matrix job. Rate limits caused empty results and two test failures (~3 min per job). Bundle tests should mock externals per TESTING.md; this aligns the skill with that policy.Type of Change
Checklist (all PRs)
pytest skills/locally (76 passed).CHANGELOG.mdupdated under[Unreleased].examples/README.md— N/A.New or updated skill
N/A —
test_skill.pyonly; no manifest or skill logic changes.Constitution & Safety
N/A — tests mock embeddings; production skill unchanged.
Related Issues
Refs #159