Backfill bundle tests for six registry skills missing test_skill.py.#164
Merged
Conversation
Every skill now ships co-located offline tests (manifest, validation, mocked execute). Fix prompt_rewriter __init__ export so pytest can collect the bundle. Refs #158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
test_skill.pyto the six registry skills that were missing bundle tests:mica_module,pii_masker,synthetic_generator,wallet_screening,pdf_form_filler, andprompt_rewriter.Each bundle test covers manifest consistency (or manifest schema where
skill.manifestis empty), input validation, and offline/mockedexecute()paths. Also fixesprompt_rewriter/__init__.pyso pytest can collect the bundle.Fixes #158
Description
Backfills co-located bundle tests so every registry skill ships
test_skill.py. No skill logic changes except theprompt_rewriterexport fix.Type of Change (Matches Issue Templates)
manifest.yaml,skill.py, andinstructions.md)base_skill.py,loader.py, etc.)Checklist (all PRs)
python -m flake8 .andpytest tests/locally (or the subset relevant to this change).CHANGELOG.mdupdated under[Unreleased]if this PR changes user-visible behavior.examples/README.mdis updated if this PR adds, renames, or removes a runnable script underexamples/.New or updated skill (complete only if this PR adds or changes a skill under
skills/)Bundle & metadata
skills/<category>/<skill_name>/(copied fromtemplates/python_skill/or equivalent).manifest.yamlhasname,version,description, validparameters, andconstitution.manifest.yamlincludesissuerwith realnameandemail(not template placeholders).short_descriptionin manifest (~80 chars) forskillware list.issuer.githubandissuer.orgset when applicable.requirementsandenv_varsare documented when the skill needs them.Logic, cognition, and UI
skill.pyis deterministic Python (no arbitrary LLM-generated code paths).instructions.mdexplains when and how to use the skill.card.jsonis present and itsissuermatchesmanifest.yaml(nameandemailat minimum).Tests & loader
test_skill.pycovers execution and schema expectations.SkillLoader.load_skill("<category>/<skill_name>")succeeds (or missing deps are documented).Documentation & catalog
docs/skills/<skill_name>.mdexists or is updated (ID, Issuer, usage).docs/skills/README.mdlists the skill with ID and Issuer.Constitution & Safety (if adding or modifying a skill)
N/A — tests only. No skill execution behavior changed.
Related Issues
Closes #158