Repository navigation
Conversation
YixinDu1
marked this pull request as ready for review
October 21, 2026 21:46
YixinDu1
force-pushed
the
yixin/1020_mt_tip_aom
branch
from
October 22, 2026 16:41
6490229 to
72b6159
Compare
Contributor
Author
|
Hi @yunqingwang1, this is a similar patch to apply multi-threading to TIP. I also tested the tool off results of TIP and compare it against the patch savings:
At the CTC thread counts the patch recovers about 24% of that time on A1 (1.2 of 5.0) and about 42% on A2 (0.8 of 1.9). |
Contributor
|
@yunqingwang1 , could you please help review again for this PR to see if you have any other comments? |
Run the full-frame TIP work, that is the TIP frame build, its loop filter and the SSE of the TIP searches, on the tile encoder's worker threads. The band builds and band SSEs of the direct output rank search stay on the main thread. The work is split into row or column jobs that write disjoint output or integer partial sums, so the bitstream does not depend on the thread count. It uses the existing tile workers and stays serial until they exist. Anchor: commit 224c347 CTC: AV2 CTC v8 (33 frames, RA) ``` Speed 4 (cpu-used=4) +--------------+-------+-------+-------+-------+-------+--------+ | Class | Y | Cb | Cr | wAvg | Enc% | Ratio | +--------------+-------+-------+-------+-------+-------+--------+ | A1 | 0.00 | 0.00 | 0.00 | 0.00 | 98.2 | N/A | | A2 | 0.00 | 0.00 | 0.00 | 0.00 | 100.0 | N/A | | Avg w/o B2 | 0.00 | 0.00 | 0.00 | 0.00 | 99.9 | N/A | +--------------+-------+-------+-------+-------+-------+--------+ Speed 5 (cpu-used=5) +--------------+-------+-------+-------+-------+-------+--------+ | Class | Y | Cb | Cr | wAvg | Enc% | Ratio | +--------------+-------+-------+-------+-------+-------+--------+ | A1 | 0.00 | 0.00 | 0.00 | 0.00 | 99.0 | N/A | | A2 | 0.00 | 0.00 | 0.00 | 0.00 | 99.6 | N/A | | Avg w/o B2 | 0.00 | 0.00 | 0.00 | 0.00 | 99.8 | N/A | +--------------+-------+-------+-------+-------+-------+--------+ Speed 6 (cpu-used=6) +--------------+-------+-------+-------+-------+-------+--------+ | Class | Y | Cb | Cr | wAvg | Enc% | Ratio | +--------------+-------+-------+-------+-------+-------+--------+ | A1 | 0.00 | 0.00 | 0.00 | 0.00 | 98.8 | N/A | | A2 | 0.00 | 0.00 | 0.00 | 0.00 | 99.2 | N/A | | Avg w/o B2 | 0.00 | 0.00 | 0.00 | 0.00 | 99.7 | N/A | +--------------+-------+-------+-------+-------+-------+--------+ Speed 6 (cpu-used=6), threads=8, row-mt=1, classes A1 and A2 only +--------------+-------+-------+-------+-------+-------+--------+ | Class | Y | Cb | Cr | wAvg | Enc% | Ratio | +--------------+-------+-------+-------+-------+-------+--------+ | A1 | 0.00 | 0.00 | 0.00 | 0.00 | 96.9 | N/A | | A2 | 0.00 | 0.00 | 0.00 | 0.00 | 98.3 | N/A | +--------------+-------+-------+-------+-------+-------+--------+ ```
YixinDu1
force-pushed
the
yixin/1020_mt_tip_aom
branch
from
October 23, 2026 21:48
72b6159 to
a747273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Run the full-frame TIP work, that is the TIP frame build, its loop filter and the SSE of the TIP searches, on the tile encoder's worker threads. The band builds and band SSEs of the direct output rank search stay on the main thread. The work is split into row or column jobs that write disjoint output or integer partial sums, so the bitstream does not depend on the thread count. It uses the existing tile workers and stays serial until they exist.
Anchor: commit 224c347
CTC: AV2 CTC v8 (33 frames, RA)