Repository navigation
Remove stale copy of Table A.2 from timing.c and keep one copy in ann… - #5601
Merged
Merged
Conversation
Contributor
Author
|
@andrey-norkin I think you missed the second instance of Table A.2 update. I have provided a fix as I was tagged in the ticket. |
urvangjoshi
approved these changes
Oct 23, 2026
urvangjoshi
left a comment
urvangjoshi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @SMPaluri for refactoring ! Looks good to me.
urvangjoshi
force-pushed
the
spaluri/Ticket5179
branch
from
October 23, 2026 17:39
123d0f8 to
990af10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Table A.2 factors were copied into three tables across two files. CWG-G075/G078 updated the copy in level.c but not the one in timing.c, which still holds the old { 1, 2, 3 } values.
Keep a single copy in annexA.c and read it through
get_bitrate_profile_factor() and get_picture_size_profile_factor().
Fix #5179