Skip to content

Reinstate multi-thread unit test for first pass - #5596

Merged
urvangjoshi merged 1 commit into
AOMediaCodec:av2-encfrom
jingninghan:vbr3
Oct 23, 2026
Merged

Reinstate multi-thread unit test for first pass#5596
urvangjoshi merged 1 commit into
AOMediaCodec:av2-encfrom
jingninghan:vbr3

Conversation

@jingninghan

@jingninghan jingninghan commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jingninghan
jingninghan force-pushed the vbr3 branch 3 times, most recently from bbaffaa to 471e089 Compare October 22, 2026 18:39
yunqingwang1
yunqingwang1 reviewed Oct 22, 2026
View reviewed changes
Comment thread test/ethread_test.cc
@yunqingwang1

yunqingwang1 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Looks good overall.

@urvangjoshi

urvangjoshi commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@jingninghan : looks like there are some failures under thread sanitizer: https://github.com/AOMediaCodec/avm/actions/runs/39833244656/job/120066712661?pr=5596

I'm attaching log for the particular shard that failed.
sanitizer.33.failure.log

P.S. The method of finding failing test (shard) is explained in the wiki: https://github.com/AOMediaCodec/avm/wiki/Reproducing-CI-Test-Failures-Locally#finding-failing-tests

@jingninghan

jingninghan commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@jingninghan : looks like there are some failures under thread sanitizer: https://github.com/AOMediaCodec/avm/actions/runs/39833244656/job/120066712661?pr=5596

I'm attaching log for the particular shard that failed. sanitizer.33.failure.log

P.S. The method of finding failing test (shard) is explained in the wiki: https://github.com/AOMediaCodec/avm/wiki/Reproducing-CI-Test-Failures-Locally#finding-failing-tests

Got it, thanks!

@urvangjoshi
urvangjoshi merged commit e2dc2df into AOMediaCodec:av2-enc Oct 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yunqingwang1 yunqingwang1 yunqingwang1 approved these changes
@urvangjoshi urvangjoshi Awaiting requested review from urvangjoshi
@yeqing-wu yeqing-wu Awaiting requested review from yeqing-wu
@leolzhao leolzhao Awaiting requested review from leolzhao

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jingninghan @yunqingwang1 @urvangjoshi @aom-bot