Skip to content

Refactor tools with multiple modes of operation #190

Description

@mnieslony

This suggestion was also brought up by @marc1uk, in reference to PR #187

Some tools (like e.g. PhaseIIADCCalibrator) have slightly different modes of operation depending on the respective use case. For example, PhaseIIADCCalibrator operates on a list of events in the EventBuilding mode, while it only expects one event per Execute step in the normal operating mode.

Currently, the different modes are realized in large if/else statement blocks that make the code a little harder to read.

As a first step, the different modes of operation could be moved to separate functions. This would already clean up the code significantly. A further step might be to move the handling of the different operation modes to a second tool and provide the main tool always with the same data format.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions