RDE additional resources fixes#80
Open
Kostr wants to merge 3 commits into
Open
Conversation
Currently the parent for all the AdditionalResourceSubURIs is set to the current PDR ResourceId. This is wrong, since the parent for both the SubURI and all the AdditionalResourceSubURIs should be set to ContainingResourceID. Correct that to fix the issue. Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Currently additional resources are not added to the resInfoMap map. Because of that records for additional resources are missing fields in the file '/tmp/ResourceRegistry_<EID>'. Add all the additional resources to the resInfoMap map to fix the issue. Tested: Verify that all the records for additional resources in the file '/tmp/ResourceRegistry_<EID>' contain all the fields. Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Currently the constructFullUriRecursive contains a workaround for the duplicate segments in the URI. Apparently this workaround was introduced to mask a bug with additional resources that earlier had their parent set to ResourceID instead of the ContainingResourceID. It is worth to notice that this workaround wasn't working for the cases when there are more than one additional resources in the PDR. For example it produced URIs: - NetworkDeviceFunctions/0 - NetworkDeviceFunctions/0/1 - NetworkDeviceFunctions/0/2 - NetworkDeviceFunctions/0/3 instead of - NetworkDeviceFunctions/0 - NetworkDeviceFunctions/1 - NetworkDeviceFunctions/2 - NetworkDeviceFunctions/3 In any case, since the bug with additional resources parent was fixed, the workaround code can be dropped. Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
raja-gade
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I've found several bugs with the handling of AdditionalResource's fields. Please review.
I don't use this fork directly as-is, therefore it would be better if you do some testing before the merge.