Repository navigation
fix(composer): real background download, window-independent downloads, window geometry log - #4
Merged
Conversation
…, window geometry log Background download - "Download in background" is its own banner action: the banner no longer comes back with the next progress update, and the composer footer shows the overall progress with a bar until the models are installed or the download fails. Downloads belong to the application - ModelDownloadCoordinatorExtensions.StartAllAsync downloads models one after the other with no window involved. DownloadModelsAsync works off the missing models until none is left (what is needed can grow while downloading), ends a round that installed nothing as a failure, and does nothing for a composer that was closed meanwhile (it used to be able to start the microphone). - A summon that finds a download running joins it in the background. - The coordinator logs the start and end of every model download. Window geometry diagnostics - ComposerGeometryLog writes every size/position decision with a summon number and the whole geometry (requested and system size, position, cap, working area, scale); bursts are throttled. Problems are logged as PROBLEM=...: content taller than the cap, size changed by the system, window outside the working area. - The page reports when its viewport stays smaller than its content (clipped intent), the symptom of a window that shows only part of the composer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background download banner no longer returns; footer shows progress. Downloads run independent of the composer window (sequential chain in Core, joined by later summons, closed composers do nothing at the end). Adds composer window geometry logging (PROBLEM= lines) and a page-side clipped diagnostic. Local gate: ./build.sh Test green, 0 warnings; independent review findings fixed.