Repository navigation
feat(composer): final whole-text polish, clear button and runtime model hints - #2
Merged
Merged
Conversation
…el hints Final polish - On stop, the whole dictation is summarized and polished as one text through PolishScheduler and IDictationPolisher, sharing the cleanup role's route. Draft.Polishing is set in the same step as Recording=false, so writing waits. - Stale polish requests are discarded by dictation/source revision; failures are reported instead of looking like success. No recursive retries. - The polish requirements are editable in Settings > Voice (PolishStyle owns validation and the default). Unusable text resolves to the default, and an invalid custom result is retried once with the default. - The fidelity gate accepts spoken filler trims and restated clauses, and still refuses lost numbers, terms and any deleted negation. - Passages end after a 2 s pause; truncated cleanup answers keep the words. Clear - A visible Clear button reuses NewDraft: it stops recording, serializes with start/stop/import (IsClearing) and keeps the target and preferences. DictationSession writes are guarded by Draft.Epoch so recognition that outlives the stop timeout cannot repopulate a cleared draft. Models - ModelUsage reports the speech models, local leases and cloud responses actually used; the UI shows a brief notice and details on the chip. - LlamaServerHost waits for active leases before replacing a role's model; changing the translation tier refreshes the open composer's model plan and generated translations (manual edits are kept). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The scenario captured the draft while the background cleanup was still racing from pending to ready, so the golden file only matched on fast machines. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final whole-dictation polish with editable requirements, visible Clear button with epoch-guarded races, runtime model hints, and safe model switching. Local gate: ./build.sh Test (Core 498 / Desktop 711 / Web 324), 0 warnings; independent code review: no findings. Real-model checks: polish on user samples; Hy-MT2 1.8B -> 7B -> 1.8B confirmed by provider responses.