Skip to content

Fix flaky DER signature weight test#3299

Merged
t-bast merged 1 commit intomasterfrom
der-weight-flaky-test
May 5, 2026
Merged

Fix flaky DER signature weight test#3299
t-bast merged 1 commit intomasterfrom
der-weight-flaky-test

Conversation

@t-bast
Copy link
Copy Markdown
Member

@t-bast t-bast commented May 5, 2026

This test was flaky because for the funding output, we provide two signatures, which means that we need twice the slack for the variable DER encoding length.

This test was flaky because for the funding output, we provide two
signatures, which means that we need twice the slack for the variable
DER encoding length.
@t-bast t-bast requested a review from pm47 May 5, 2026 13:00
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.64%. Comparing base (129df36) to head (955c34f).
⚠️ Report is 16 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3299      +/-   ##
==========================================
- Coverage   88.67%   88.64%   -0.04%     
==========================================
  Files         221      222       +1     
  Lines       21453    21571     +118     
  Branches      832      868      +36     
==========================================
+ Hits        19023    19121      +98     
- Misses       2430     2450      +20     

see 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-bast t-bast merged commit 0f5d4b8 into master May 5, 2026
1 of 2 checks passed
@t-bast t-bast deleted the der-weight-flaky-test branch May 5, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants