Skip to content

Add an explicit dance.selections.clear command.#412

Merged
71 merged 1 commit into
71:masterfrom
sdoerner:clearSelection
Nov 15, 2025
Merged

Add an explicit dance.selections.clear command.#412
71 merged 1 commit into
71:masterfrom
sdoerner:clearSelection

Conversation

@sdoerner

Copy link
Copy Markdown
Contributor

This allows using this functionality within environments that prohibit arbitrary code execution (such as certain CSPs).

This essentially forks filter() and removes interactive expression selection.

Fixes: #349

@71 71 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I agree with the idea, just a couple of minor comments.

Comment thread src/commands/selections.ts
Comment thread src/commands/selections.ts Outdated
This allows using this functionality within environments that prohibit
arbitrary code execution (such as certain CSPs).

This essentially forks filter() and removes interactive expression
selection.

Fixes: 71#349

@sdoerner sdoerner left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. I implemented the requested changes.

Please take another look.

Comment thread src/commands/selections.ts
Comment thread src/commands/selections.ts Outdated

@71 71 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@71 71 merged commit 3183056 into 71:master Nov 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dance.selections.clear.secondary not working under Content Security Policy

2 participants