Repository navigation
fix: seed authorization before the server listens - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Seeds the authorization model before the server starts listening, so
/readyzno longer reports ready while early authenticated requests are still rejected with 403, and lets the soak harness run the node under Bun and with each web server.Depends on 3sixtyglobal/engine#28 being released, as it uses the new
engineReadyparameter ofEngineServer.start.🔄 Type of Change
🛠️ Changes Made
seedAuthorizationDefaultsandfinalizeMigrationsin theengineReadycallback ofserver.start, before the web server listens; previously they ran after, leaving a window of about 1.1 s on Bun and 0.33 s on Node where/readyzwas 200 but the model was incompleteSOAK_RUNTIME(nodeorbun) andSOAK_WEB_SERVER_TYPE(fastify,honoornative) to the soak harness, recorded underconfiginreport.jsonruntimeandweb_server_typeinputs to the soak workflow, with a Bun setup step when the runtime isbun; they apply to profiles which start a local node🧪 Testing