Repository navigation
feat: add an account context key - #33
Merged
Merged
Conversation
psyhedeliq
approved these changes
Oct 23, 2026
4 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add an account context key that is separate from the user key. The account id is the stable identifier for a sign-in. It is not a DID.
ContextIdKeys.Userstays"user"and continues to mean the DID.This is the framework step for trade-data issue 7, on
feature/account-context-key. The api-auth half is pull request 2. Nothing in this repository writes the key. api-auth sets it after a token is verified. Node does not register it.userOrganizationis already set the same way and is not registered. An empty feature list would bind the DID handler, becauseIs.arrayValue([])is false, and that handler would reject the account id.🔄 Type of Change
🛠️ Changes Made
ContextIdKeys.Accountis"account", added besideUserOrganizationinpackages/context/src/models/contextIdKeys.ts. The exported type picks the new value up from the object. No handler is registered for it.ContextIdHelper.guardalready accepts a non-empty string when a key has no handler.ContextIdKeys.Useris unchanged.🧪 Testing
ContextIdHelpertests check that a UUID is accepted onContextIdKeys.Accountwhen no handler is registered, and that an empty account id throwsguard.stringEmpty.pnpm run qualitypassed locally.