Skip to content

Fix/#513 홈에서 튜토리얼 진입 시 네비바 사라짐 해결 - #514

Merged
y-eonee merged 2 commits into
developfrom
fix/#513-온보딩
Aug 30, 2026

Hidden character warning

The head ref may contain hidden characters: "fix/#513-\uc628\ubcf4\ub529"
Merged

y-eonee merged 2 commits into
developfrom
fix/#513-온보딩

Conversation

@y-eonee

@y-eonee y-eonee commented Aug 30, 2026

Copy link
Copy Markdown
Member

🔗 연결된 이슈

📄 작업 내용

  • 홈에서 튜토리얼 진입 시 네비바가 보이지 않는 오류를 해결했습니다.
  • 앱잼 때 처음 만들어졌던 초기 온보딩 파일이 그대로 남아있어서 관련 뷰, 이미지에셋을 전부 삭제했습니다.
구현 내용 IPhone 13 mini
GIF

Summary by CodeRabbit

  • 변경 사항

    • 기존 온보딩 화면과 단계별 콘텐츠, 건너뛰기 기능이 제거되었습니다.
    • 온보딩 관련 이미지 리소스가 삭제되었습니다.
  • 버그 수정

    • 튜토리얼 화면 진입 시 내비게이션 바가 정상적으로 표시됩니다.

@y-eonee y-eonee self-assigned this Aug 30, 2026
@y-eonee y-eonee linked an issue Aug 30, 2026 that may be closed by this pull request
1 task
@y-eonee y-eonee added the fix 버그나 오류 해결 label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ffe00837-518b-4adb-a9d2-c84cd0e6fdf2

📥 Commits

Reviewing files that changed from the base of the PR and between 063fd2c and 4b4a89b.

⛔ Files ignored due to path filters (5)
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/fifth.imageset/5th.svg is excluded by !**/*.svg
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/first.imageset/1st.svg is excluded by !**/*.svg
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/fourth.imageset/4th.svg is excluded by !**/*.svg
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/second.imageset/2nd.svg is excluded by !**/*.svg
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/third.imageset/3rd.svg is excluded by !**/*.svg
📒 Files selected for processing (11)
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/View/Onboarding/OnboardingContentView.swift
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/View/Onboarding/OnboardingHeaderView.swift
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/View/Onboarding/OnboardingView.swift
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/ViewController/OnboardingViewController.swift
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Tutorial/TutorialModalViewController.swift
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/fifth.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/first.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/fourth.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/second.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/third.imageset/Contents.json
💤 Files with no reviewable changes (10)
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/fourth.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/third.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/first.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/ViewController/OnboardingViewController.swift
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/View/Onboarding/OnboardingView.swift
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/fifth.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/View/Onboarding/OnboardingContentView.swift
  • ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/second.imageset/Contents.json
  • ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/View/Onboarding/OnboardingHeaderView.swift

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

온보딩 화면과 관련 이미지 에셋을 삭제했습니다. 온보딩 단계 전환 및 정보 화면 이동 로직을 제거했습니다. 튜토리얼 화면에서는 네비게이션 바를 표시합니다.

Changes

온보딩 및 튜토리얼 흐름

Layer / File(s) Summary
온보딩 구현 및 에셋 제거, 튜토리얼 네비게이션 표시
ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/View/Onboarding/*, ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Home/ViewController/OnboardingViewController.swift, ByeBoo-iOS/ByeBoo-iOS/Presentation/Feature/Tutorial/TutorialModalViewController.swift, ByeBoo-iOS/ByeBoo-iOS/Resource/Assets.xcassets/Onboarding/*
온보딩 뷰, 헤더 뷰, 콘텐츠 뷰, 뷰 컨트롤러와 관련 이미지 에셋을 삭제했습니다. 튜토리얼 화면 로드 시 네비게이션 바를 표시합니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 4b4a8

This change restores the navigation bar when entering the tutorial and removes obsolete onboarding UI and assets; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: juri123123, dev-domo

Poem

토끼가 온보딩 그림을 살며시 지우고
튜토리얼 문 앞에 네비게이션 바를 세웠네
단계들은 조용히 당근 수레를 타고
화면은 더 단정한 길을 달리네
깡충, 변경 사항을 확인하자!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 홈에서 튜토리얼 진입 시 네비게이션 바가 사라지는 문제를 수정한 주요 변경 사항을 정확하게 설명합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#513-온보딩

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@y-eonee
y-eonee merged commit cdd1d2b into develop Aug 30, 2026
2 checks passed
@y-eonee
y-eonee deleted the fix/#513-온보딩 branch August 30, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그나 오류 해결 나연🐹

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] 온보딩 네비바 사라짐 해결

1 participant