Repository navigation
Guarding against higher genus cusps and singular locus in Triangulation_to_Manifold. - #158
unhyperbolic wants to merge 1 commit into
Conversation
|
If we were to start from scratch, I would make a method Triangulation.remove_finite_vertices and the user has to explicitly call it before calling Triangulation.with_hyperbolic_structure instead of Triangulation.with_hyperbolic_structure doing it for the user. But, for backwards compatibility, we can't change it. But we do need to guard against singular locus or higher genus vertex links in Triangulation.with_hyperbolic_structure. I just don't know a good name for the helper. I went with orb_all_cusps_are_real_or_finite, but I don't like the name. Maybe it should be is_closed_or_cusped_manifold? That would be consistent with defining a cusp to be a vertex with like of Euler characteristic zero. |
NathanDunfield
left a comment
NathanDunfield
left a comment
There was a problem hiding this comment.
The name orb_all_cusps_are_real_or_finite seems fine, or at least I can't think of a better one.
|
My suggestion would be "orb_all_vertex_links are standard". |
No description provided.