[unhyperbolic]

No description provided.

[unhyperbolic]

Seemed like an obvious simplification - I was wondering whether I am missing something here.

[NathanDunfield]

I don't see any issue with this simplification.

[culler]

I think the original intention was to provide a function which can construct a Manifold or a ManifoldHP from a Triangulation. However, currently we provide two such functions, one in the SnapPy extension and one in the SnapPyHP extension. Moreover, they don't work as expected.
The following works:

>>> T = Triangulation('m004')
>>> M = SnapPy.Manifold_from_Triangulation(T, manifold_class=Manifold)
>>> type(M)
<class 'snappy.Manifold'>

But the following does not:

>>> M = SnapPyHP.Manifold_from_Triangulation(T, manifold_class=ManifoldHP)
Traceback (most recent call last):
  File "<python-input-30>", line 1, in <module>
    M = SnapPyHP.Manifold_from_Triangulation(T, manifold_class=ManifoldHP)
TypeError: Argument 'T' has incorrect type (expected SnapPyHP.Triangulation, got Triangulation)

and neither does this:

>>> M = SnapPy.Manifold_from_Triangulation(T, manifold_class=ManifoldHP)
Traceback (most recent call last):
  File "<python-input-31>", line 1, in <module>
    M = SnapPy.Manifold_from_Triangulation(T, manifold_class=ManifoldHP)
  File "src/snappy/extensions/SnapPy/cython_src/core/basic.pyx", line 605, in SnapPy.Manifold_from_Triangulation
TypeError: Cannot convert ManifoldHP to SnapPy.Manifold

One might expect that a Triangulation could be used to construct either a Manifold or a ManifoldHP, but that is not the case.

It is true that one can currently construct a ManifoldHP from a SnapPyHP.Triangulation by passing manifold_class=ManifoldHP to SnapPyHP.Manifold_from_Triangulation.

Will this change make the situation any better?