fix(acme): 修复 internal 载荷属性在 AOT 下被丢弃导致 finalize CSR 为空 - #32
Merged
Conversation
Order.Payload.Csr 与 Account.Payload.OnlyReturnExisting 声明为 internal, System.Text.Json 源生成器只序列化 public 成员,二者被静默丢弃: - finalize 请求缺少 csr 字段,Let's Encrypt 报 'asn1: syntax error: sequence truncated' - onlyReturnExisting 丢失会破坏"仅返回已有账号"流程 改为 public 并加 [JsonInclude]。外层 Payload 类本身是 internal, 不会扩大公共 API 表面。 本地验证:真实 CSR 经签名后 csr 字段完整往返(DER 278B,tag 0x30), onlyReturnExisting 正常序列化。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order.Payload.Csr 与 Account.Payload.OnlyReturnExisting 声明为 internal, System.Text.Json 源生成器只序列化 public 成员,二者被静默丢弃:
改为 public 并加 [JsonInclude]。外层 Payload 类本身是 internal, 不会扩大公共 API 表面。
本地验证:真实 CSR 经签名后 csr 字段完整往返(DER 278B,tag 0x30),
onlyReturnExisting 正常序列化。
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context