Conversation
1jehuang
marked this pull request as draft
September 15, 2026 21:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1269. Fixes #1275.
Two independently reviewable, narrow fixes from issue triage:
ambient:statusreportsenabled: true#1269: Re-readambient.enabledat the loop gate instead of retaining the startup value. Preserve explicitAmbientStatus::Disabled, startup-only reply pollers, and the existing scheduler/wake policy. Add a disk-config regression covering false → true → false and the explicit-stop override.Alt. No production badge rendering changes.Commits: 2200140 (#1269), 180e95d (#1275).
Verification
Performed on Linux x86_64 through the coordinated self-dev test/build queue:
JCODE_HOMEand[display] copy_badge_alt_label = "⌥": 18 != 16 before the fixture fix.scripts/dev_cargo.sh test --offline --locked -p jcode-tui --lib copy_badge -- --test-threads=1: 16 passed with defaultAlt, and 16 passed with configured⌥, including platform-default and trimmed-override tests.--exact --test-threads=1under each label: 4 exact invocations passed on the final formatted tree.scripts/dev_cargo.sh test --offline --locked -p jcode-app-core --lib ambient::runner:: -- --test-threads=1: 6 passed, including the new toggle regression and real running-loop hot-reload regression and existing disabled-ambient scheduled-task coverage.scripts/dev_cargo.sh build --profile selfdev -p jcode --bin jcode: passed viaselfdev build.git diff --checkandrustfmt --check --edition 2024on all three changed files: passed.Measured behavior follow-up
Additional regression coverage in c515991 exercises the actual
run_loop, not just the extracted gate. It starts disabled, editsconfig.tomlto enable ambient without invalidating the cache, and observes the loop enterPausedfor an active user session after nudging it. This exercises file fingerprint reload and the production gate without model inference.Restoring the old startup-snapshot gate made this exact test fail after its 3-second observation deadline. Restoring the fix made it pass, along with all six ambient runner tests. This establishes a behavioral improvement at the real loop boundary, while not claiming a full CLI/daemon or native macOS acceptance run.
Limits and non-goals
⌥coverage exercises the reported width difference, not the macOS OS/runtime.Hosted CI follow-up
This PR is draft pending hosted checks and native macOS validation. The CI run, Windows smoke, and iOS workflow all failed before creating any jobs.
gh run viewreports a likely workflow-file issue, and these unchanged base workflows each contain duplicate top-levelenvmaps. The existing repair is tracked by #1191 / PR #1193 and is not duplicated here. Require Linked Issue passed. Local test/build results above remain valid, but this is not green hosted CI.Jcode agent (automated triage), on behalf of @1jehuang