Skip to content

fix: honor ambient hot-reload and platform-aware badge tests - #1276

Draft
1jehuang wants to merge 3 commits into
masterfrom
fix/issue-triage-20260915
Draft

1jehuang wants to merge 3 commits into
masterfrom
fix/issue-triage-20260915

Conversation

@1jehuang

@1jehuang 1jehuang commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes #1269. Fixes #1275.

Two independently reviewable, narrow fixes from issue triage:

Commits: 2200140 (#1269), 180e95d (#1275).

Verification

Performed on Linux x86_64 through the coordinated self-dev test/build queue:

  • Reproduced the original badge assertion with an isolated JCODE_HOME and [display] copy_badge_alt_label = "⌥": 18 != 16 before the fixture fix.
  • scripts/dev_cargo.sh test --offline --locked -p jcode-tui --lib copy_badge -- --test-threads=1: 16 passed with default Alt, and 16 passed with configured , including platform-default and trimmed-override tests.
  • Ran each of the two changed badge fixtures separately with --exact --test-threads=1 under each label: 4 exact invocations passed on the final formatted tree.
  • scripts/dev_cargo.sh test --offline --locked -p jcode-app-core --lib ambient::runner:: -- --test-threads=1: 6 passed, including the new toggle regression and real running-loop hot-reload regression and existing disabled-ambient scheduled-task coverage.
  • scripts/dev_cargo.sh build --profile selfdev -p jcode --bin jcode: passed via selfdev build.
  • git diff --check and rustfmt --check --edition 2024 on all three changed files: passed.

Measured behavior follow-up

Additional regression coverage in c515991 exercises the actual run_loop, not just the extracted gate. It starts disabled, edits config.toml to enable ambient without invalidating the cache, and observes the loop enter Paused for an active user session after nudging it. This exercises file fingerprint reload and the production gate without model inference.

Restoring the old startup-snapshot gate made this exact test fail after its 3-second observation deadline. Restoring the fix made it pass, along with all six ambient runner tests. This establishes a behavioral improvement at the real loop boundary, while not claiming a full CLI/daemon or native macOS acceptance run.

Limits and non-goals

Hosted CI follow-up

This PR is draft pending hosted checks and native macOS validation. The CI run, Windows smoke, and iOS workflow all failed before creating any jobs. gh run view reports a likely workflow-file issue, and these unchanged base workflows each contain duplicate top-level env maps. The existing repair is tracked by #1191 / PR #1193 and is not duplicated here. Require Linked Issue passed. Local test/build results above remain valid, but this is not green hosted CI.


Jcode agent (automated triage), on behalf of @1jehuang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant