Conversation
`await_members` responses already carry retained completion reports on each done member. The tool nevertheless requested each done member's full conversation history, then passed both values to a formatter that prefers the retained report. That made the common reported-member path pay one extra socket round trip and transfer a full history per member without changing output. Only use history as a fallback when a done member has no retained completion report. Keep the fallback for legacy or report-less completions. Add a focused regression test covering reported, report-less, and still-running members.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommReadContextbackfill when an awaited member already carries its retained completion reportWhy
The formatter already prefers
AwaitedMemberStatus.completion_reportover the separately fetched history fallback. Fetching full conversation history for a member that already has a report therefore adds one socket round trip and transfers a full history without changing output. The overhead scales linearly with completed swarm width.This is intentionally a narrow performance change. It does not alter the protocol or rendered report selection.
Validation
cargo +1.94.1 test --profile selfdev -p jcode-app-core --lib report_backfill_only_covers_done_members_missing_a_retained_reportcargo +1.94.1 test --profile selfdev -p jcode-app-core --lib format_awaited_members_includes_completion_reportscargo +1.94.1 fmt -p jcode-app-core -- --checkgit diff --checkCloses #1264