fix(cli): align Go workspace paths for dependency commands - #34
Closed
caorushizi wants to merge 2 commits into
Closed
caorushizi wants to merge 2 commits into
caorushizi wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and all reviewed changes have approval readiness.
Pull request overview
Aligns Go dependency commands with canonical workspace paths for consistent symlinked workspace resolution.
Changes:
- Normalizes workspace roots,
PWD, andGOWORK. - Propagates the normalized environment to Go commands.
- Expands symlink-path test coverage.
File summaries
| File | Description |
|---|---|
packages/cli/internal/modules/dependencies/service.go |
Canonicalizes Go workspace paths and command environments. |
packages/cli/internal/modules/dependencies/service_test.go |
Adds coverage for symlinked workspace roots, files, parents, and PWD. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.