fix(ci): enforce native platform checks before merging - #33
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments were identified.
Pull request overview
Updates Go workspace path handling and enforces native platform checks before merging.
Changes:
- Aligns workspace,
PWD, andGOWORKpaths. - Adds symlink and path-alias regression coverage.
- Enables native platform checks on pull requests and documents validation.
File summaries
| File | Description |
|---|---|
packages/cli/internal/modules/dependencies/service.go |
Aligns Go workspace path handling. |
packages/cli/internal/modules/dependencies/service_test.go |
Adds workspace path regression tests. |
CONTRIBUTING.md |
Documents local and CI platform coverage. |
.github/workflows/ci.yml |
Enables native platform PR checks. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs previously skipped macOS, and master required only the Linux lint and test checks, so a failing Windows check could still be merged.
Run macOS tests on every PR and pair the workflow with required lint, test, test-windows, and test-macos checks in the Protect master ruleset. Document that local checks cover only the host OS; race testing remains on master and manual runs.
Use one workspace-root spelling for the child working directory, PWD, and GOWORK so native Windows module loading accepts workspace path aliases. Regression coverage includes symlinked GOWORK parents and PWD aliases.
Validation: task pre-push passed. All four required checks passed on this PR: https://github.com/1cli-team/one-cli/actions/runs/34870620617. The active ruleset now requires all four checks, and this PR remained BLOCKED after Linux lint/test passed while the native platform tests were still running. The Go dependency fix also passed native Linux, Windows, macOS, and race checks in https://github.com/1cli-team/one-cli/actions/runs/34869772049.