fix(cli): resolve symlink paths in workspace checks and create output - #32
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Canonicalized relative paths can be incorrect from a symlinked logical working directory.
Pull request overview
Updates CLI create-path output and Go workspace validation to handle symlinked paths consistently.
Changes:
- Resolve symlink-aware paths for create output.
- Compare workspace files by filesystem identity.
- Add regression coverage for symlink scenarios.
File summaries
| File | Summary |
|---|---|
packages/cli/internal/transport/cobra/create/result.go |
Symlink-aware create-path resolution. |
packages/cli/internal/transport/cobra/create/result_test.go |
Tests symlink-aware relative paths. |
packages/cli/internal/modules/dependencies/service.go |
Symlink-equivalent workspace checks. |
packages/cli/internal/modules/dependencies/service_test.go |
Tests accepted and rejected workspace paths. |
Review details
Suppressed comments (1)
packages/cli/internal/transport/cobra/create/result.go:80
- Canonicalizing both paths before computing a relative
cdpath can produce a path that is wrong from the user's logical working directory. For example, with cwd/tmp/long/link/sub(link -> /tmp/root) and target/tmp/other, this returns../../other, which a shell started in the logical cwd resolves as/tmp/long/other, not/tmp/other. Validate the computed relative path against the original cwd and fall back to the originalfilepath.Rel(cwd, targetDir)(or emit an absolute canonical target) when it is not valid.
rel, err := filepath.Rel(resolveDisplayPath(cwd), resolveDisplayPath(targetDir))
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.