Skip to content

fix(upgrade): resolve application upgrade failures - #13888

Merged
wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@openresty
Sep 22, 2026
Merged

wanghe-fit2cloud merged 1 commit into
dev-v2from
pr@dev-v2@openresty

Conversation

@zhengkunwang223

@zhengkunwang223 zhengkunwang223 commented Sep 22, 2026

Copy link
Copy Markdown
Member

Refs #13688

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挕 Codex Review

} else if err = appInstallRepo.Save(context.Background(), &u.candidate); err != nil {
return err

P2 Badge Refresh persisted container names after the new Compose is started

For upgrades using the supported custom Compose editor that rename an explicit container_name or change the service set, candidate still carries original.ContainerName and that stale value is saved here. The deleted readiness helper was also the only post-upgrade discovery that replaced it with the containers actually created; later syncAppInstallStatus queries only the stored names, so it can mark the upgraded application as missing/error and omit newly introduced services. Recompute and persist the current container names before saving the candidate.

鈩癸笍 About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 馃憤.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread agent/app/service/app_upgrade.go
Comment thread agent/app/service/app_upgrade.go
@wanghe-fit2cloud
wanghe-fit2cloud merged commit f984917 into dev-v2 Sep 22, 2026
3 checks passed
@wanghe-fit2cloud
wanghe-fit2cloud deleted the pr@dev-v2@openresty branch September 22, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants