fix(upgrade): resolve application upgrade failures - #13888
Conversation
There was a problem hiding this comment.
馃挕 Codex Review
1Panel/agent/app/service/app_upgrade.go
Lines 457 to 458 in 70594d1
For upgrades using the supported custom Compose editor that rename an explicit container_name or change the service set, candidate still carries original.ContainerName and that stale value is saved here. The deleted readiness helper was also the only post-upgrade discovery that replaced it with the containers actually created; later syncAppInstallStatus queries only the stored names, so it can mark the upgraded application as missing/error and omit newly introduced services. Recompute and persist the current container names before saving the candidate.
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
70594d1 to
c0f91cb
Compare
Refs #13688