Repository navigation
Return stable empty values from the editor store selectors - #160
Merged
s3rgiosan merged 2 commits intoNov 19, 2026
Merged
Conversation
getRelationships and getRelatedEntities return shared empty values when the store has no data, so useSelect gets the same reference on each call. The editor bundles are rebuilt.
rickalee
previously approved these changes
Nov 19, 2026
s3rgiosan
enabled auto-merge (squash)
November 19, 2026 20:21
…elector-results # Conflicts: # dist/js/block-editor.asset.php # dist/js/block-editor.js # dist/js/classic-editor.asset.php # dist/js/classic-editor.js
fabiankaegy
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159.
Changes
getRelationshipsreturns one shared empty object when the post ID isnullor the store has no entry.getRelatedEntitiesreturns one shared empty array in the same cases.dist/diff also has the output changes from the currentpackage-lock.json.Testing
npx 10up-toolkit test-unit-jest --env=node assets/jspasses (28 tests). The two new tests fail without the fix.npm teststops before it runs tests becausejest-environment-jsdomis not installed.SCRIPT_DEBUGtotrueand open a post with a relationship in the block editor. The console shows nouseSelectwarnings forrelationshipsorrelatedEntities.