fix: give the release artifact budgets several releases of headroom - #696
Merged
Merged
Conversation
The 292_000/1_120_000 pair left 207/152 bytes of headroom over v1.40.0, so v1.41.0's version pull request failed the unpacked budget with the release tier blocking on it — the same CHANGELOG-growth wall the budget comment already documents twice. Raise to 296_000/1_136_000 (~15 releases of changelog growth) per the comment's own guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks v1.41.0: the version PR (#695) fails
Performance budget exceeded: unpacked artifact 1120152 bytesagainst the 1_120_000 budget — 152 bytes of CHANGELOG growth, the third occurrence of the wall documented in the budget comment. Bumps packed/unpacked to 296_000/1_136_000 (~15 releases of headroom).